Skip to content

Comments Pagination Block: Refactor settings panel to use ToolsPanel #70245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 29, 2025
Merged

Comments Pagination Block: Refactor settings panel to use ToolsPanel #70245

merged 3 commits into from
May 29, 2025

Conversation

nani-samireddy
Copy link
Contributor

@nani-samireddy nani-samireddy commented May 28, 2025 •
edited
Loading

Issue: #70244
Part of: #67813

What?

Refactored Comments Pagination Block code to include ToolsPanel instead of PanelBody.

Closes #70244

Screenshots or screencast

Before After
image image

@github-actions GitHub Actions
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @nani-samireddy! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label May 28, 2025
@nani-samireddy nani-samireddy marked this pull request as ready for review May 28, 2025 14:32
@github-actions GitHub Actions
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: nani-samireddy <nanisamireddy@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@nani-samireddy nani-samireddy mentioned this pull request May 28, 2025
Closed
@t-hamano t-hamano added [Type] Enhancement A suggestion for improvement. [Block] Comments Pagination Affects the Comments Pagination Block labels May 29, 2025
t-hamano
t-hamano reviewed May 29, 2025
View reviewed changes
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

I've left some feedback, so I'd appreciate it if you could check it.

Additionally, it's recommended to add the dropdownMenuProps to the ToolsPanel component so that the dropdown is placed beside the block sidebar.

Example:

gutenberg/packages/block-library/src/audio/edit.js

Line 177 in a3b72ee

dropdownMenuProps={ dropdownMenuProps }

@nani-samireddy nani-samireddy requested a review from t-hamano May 29, 2025 03:51
@nani-samireddy
Copy link
Contributor Author

Thank you for the feedback @t-hamano!
I have added the required changes

t-hamano
t-hamano approved these changes May 29, 2025
View reviewed changes
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@t-hamano t-hamano merged commit 18a6dd5 into WordPress:trunk May 29, 2025
64 of 65 checks passed
@github-actions github-actions bot added this to the Gutenberg 21.0 milestone May 29, 2025
chriszarate pushed a commit to chriszarate/gutenberg that referenced this pull request Jul 1, 2025
@nani-samireddy @t-hamano @chriszarate
Comments Pagination Block: Refactor settings panel to use ToolsPanel (W…
9c594d4 
…ordPress#70245)

* Refactor Settings panel of Comments Pagination block to use ToolsPanel instead of PanelBody

* fix: update the dropdown label for comments pagination block settings

* chore: add dropdownMenuProps in comments pagination toolspanel

Co-authored-by: nani-samireddy <nanisamireddy@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-hamano t-hamano t-hamano approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@fabiankaegy fabiankaegy Awaiting requested review from fabiankaegy fabiankaegy is a code owner

Assignees
No one assigned
Labels
[Block] Comments Pagination Affects the Comments Pagination Block First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
Gutenberg 21.0
Development

Successfully merging this pull request may close these issues.

Refactor "Settings" panel of Comments Pagination block to use ToolsPanel instead of PanelBody
2 participants
@nani-samireddy @t-hamano