-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Block drag & drop: Enable mouse click on input/textarea elements in Firefox #69781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Size Change: +29 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @t-hamano!
…irefox (#69781) Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: audrasjb <audrasjb@git.wordpress.org>
I just cherry-picked this PR to the wp/6.8 branch to get it included in the next release: a3c46b7 |
…irefox (WordPress#69781) Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: audrasjb <audrasjb@git.wordpress.org>
Closes #69779
Related PRs:
cc @ellatrix @youknowriad
What?
This PR fixes an issue where when a block contains
input
ortextarea
, its values cannot be selected with the mouseclick.Why?
This problem is related to the Firefox bug: - 965800 - Text cursor (caret) ignores mouse click on inputs with draggable parent
In Firefox, the
draggable
andcontenteditable
attributes don't play well. Therefore, there is logic inside it that removes thedraggable
attribute when you click inside thecontenteditable
element.However, this logic does not apply to
input
andtextarea
elements, as they do not have thecontenteditable
attribute, even though they have text that is clickable with the mouse.How?
Add a check whether the clicked element is
input
ortextearea
element or not. I would have liked to use theisInputOrTextArea()
function, but it's not exposed.Testing Instructions
Core Blocks
HTML Native Elements
Paste the following code into the browser console panel. If you can't paste, access
about:config
and setdom.event.clipboardevents.enabled
tofalse
.Code
input[type="number"]
textarea
Screenshots or screencast
Berfore
84ea1887334476819d79f8e40b548df8.mp4
After
83f45e60ceb5b6b555218db6e3f360f3.mp4