-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Query Total: Update the block color support settings #69500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Query Total: Update the block color support settings #69500
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix @HILAYTRIVEDI. This lgtm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
This PR is strictly an enhancement, but the Query Total block is shipped for the first time to WP 6.8, so I personally think it's a good idea to backport this PR to 6.8.
cc @Mamaduka
Note: This is just a tiny follow-up task, but we don't have a unique label for it. That's the only reason for using the "Enhancement" label here. |
* Fix: Added text color support along with background color support. * Remove redudant field definition --------- Co-authored-by: HILAYTRIVEDI <hilayt24@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: sarthaknagoshe2002 <sarthaknagoshe2002@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: code-with-mehedi <mehedi_csit@git.wordpress.org> Co-authored-by: carolinan <poena@git.wordpress.org>
I just cherry-picked this PR to the wp/6.8 branch to get it included in the next release: 95d6620 |
* Fix: Added text color support along with background color support. * Remove redudant field definition --------- Co-authored-by: HILAYTRIVEDI <hilayt24@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: sarthaknagoshe2002 <sarthaknagoshe2002@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: code-with-mehedi <mehedi_csit@git.wordpress.org> Co-authored-by: carolinan <poena@git.wordpress.org>
What?
Closes #69489
Why?
This PR will add the text support along with BG color support.
How?
This PR will add the text support in the block.json
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast