Skip to content

Query Total: Update the block color support settings #69500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 10, 2025

Conversation

HILAYTRIVEDI
Copy link
Contributor

What?

Closes #69489

Why?

This PR will add the text support along with BG color support.

How?

This PR will add the text support in the block.json

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

Screenshot 2025-03-09 at 9 06 53 PM

Copy link

github-actions bot commented Mar 9, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: HILAYTRIVEDI <hilayt24@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: sarthaknagoshe2002 <sarthaknagoshe2002@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: code-with-mehedi <mehedi_csit@git.wordpress.org>
Co-authored-by: carolinan <poena@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Contributor

@sarthaknagoshe2002 sarthaknagoshe2002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @HILAYTRIVEDI. This lgtm.

@Mamaduka Mamaduka added [Type] Enhancement A suggestion for improvement. [Block] Query Total Affects the query total block labels Mar 10, 2025
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

This PR is strictly an enhancement, but the Query Total block is shipped for the first time to WP 6.8, so I personally think it's a good idea to backport this PR to 6.8.

cc @Mamaduka

@Mamaduka Mamaduka added [Type] Bug An existing feature does not function as intended [Type] Enhancement A suggestion for improvement. and removed [Type] Enhancement A suggestion for improvement. [Type] Bug An existing feature does not function as intended labels Mar 10, 2025
@github-project-automation github-project-automation bot moved this to 🔎 Needs Review in WordPress 6.8 Editor Tasks Mar 10, 2025
@Mamaduka Mamaduka changed the title Added text color support along with background color support. Query Total: Update the block color support settings Mar 10, 2025
@Mamaduka Mamaduka added the Backport to WP 6.8 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Mar 10, 2025
@Mamaduka
Copy link
Member

Note: This is just a tiny follow-up task, but we don't have a unique label for it. That's the only reason for using the "Enhancement" label here.

@t-hamano t-hamano merged commit 1d646ec into WordPress:trunk Mar 10, 2025
58 checks passed
@github-project-automation github-project-automation bot moved this from 🔎 Needs Review to ✅ Done in WordPress 6.8 Editor Tasks Mar 10, 2025
@github-actions github-actions bot added this to the Gutenberg 20.5 milestone Mar 10, 2025
@github-actions github-actions bot removed the Backport to WP 6.8 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Mar 10, 2025
gutenbergplugin pushed a commit that referenced this pull request Mar 10, 2025
* Fix: Added text color support along with background color support.

* Remove redudant field definition

---------

Co-authored-by: HILAYTRIVEDI <hilayt24@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: sarthaknagoshe2002 <sarthaknagoshe2002@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: code-with-mehedi <mehedi_csit@git.wordpress.org>
Co-authored-by: carolinan <poena@git.wordpress.org>
Copy link

I just cherry-picked this PR to the wp/6.8 branch to get it included in the next release: 95d6620

@github-actions github-actions bot added the Backported to WP Core Pull request that has been successfully merged into WP Core label Mar 10, 2025
chriszarate pushed a commit to chriszarate/gutenberg that referenced this pull request Jul 1, 2025
* Fix: Added text color support along with background color support.

* Remove redudant field definition

---------

Co-authored-by: HILAYTRIVEDI <hilayt24@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: sarthaknagoshe2002 <sarthaknagoshe2002@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: code-with-mehedi <mehedi_csit@git.wordpress.org>
Co-authored-by: carolinan <poena@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backported to WP Core Pull request that has been successfully merged into WP Core [Block] Query Total Affects the query total block [Type] Enhancement A suggestion for improvement.
Projects
Development

Successfully merging this pull request may close these issues.

Query total: Only the background color shows by default in the color settings
4 participants