Skip to content

Comment Author Name Block: Refactor setting panel to use ToolsPanel #69407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

shimotmk
Copy link
Contributor

@shimotmk shimotmk commented Mar 4, 2025

What?

Part of #67813

Make the settings panel more consistent with other blocks

Testing Instructions

  1. Open the editor where the comment block is located
  2. Insert a Comment Author Name block
  3. Open the settings panel
  4. You can see that you can set it up just like before.

Testing Instructions for Keyboard

Screenshots or screencast

Before After
before after

Copy link

github-actions bot commented Mar 4, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: shimotmk <shimotomoki@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@t-hamano t-hamano closed this May 25, 2025
@t-hamano t-hamano reopened this May 25, 2025
@t-hamano
Copy link
Contributor

@shimotmk do you mind rebasing this PR? One of the CIs seems to fail.

@shimotmk shimotmk force-pushed the enhancement/refactor-comment-author-name-block-control-panel branch from dca84bd to 8dca032 Compare May 25, 2025 21:03
@t-hamano t-hamano merged commit a5d2887 into WordPress:trunk May 26, 2025
68 of 69 checks passed
@github-actions github-actions bot added this to the Gutenberg 21.0 milestone May 26, 2025
@shimotmk shimotmk deleted the enhancement/refactor-comment-author-name-block-control-panel branch May 26, 2025 04:21
chriszarate pushed a commit to chriszarate/gutenberg that referenced this pull request Jul 1, 2025
…ordPress#69407)

Co-authored-by: shimotmk <shimotomoki@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Comment Author Name Affects the Comment Author Name Block [Package] Block library /packages/block-library [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor "Settings" panel of Comment Author Name block to use ToolsPanel instead of PanelBody
3 participants