Refactor Site Logo "Settings" Panel to Use ToolsPanel #67972

NidhiDhandhukiya74 · 2024-12-13T11:02:19Z

What?

Convert the ~~"Media"~~"Settings" panel of the Site Logo block to use ToolsPanel instead of PanelBody

Part of :- #67813
Part of :- #67936

Screenshots or screencast

`

Before	After

`

github-actions · 2024-12-13T11:02:36Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @NidhiDhandhukiya.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: NidhiDhandhukiya.

Co-authored-by: NidhiDhandhukiya74 <nidhidhandhukiya@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

github-actions · 2024-12-13T11:02:54Z

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @NidhiDhandhukiya74! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

Mamaduka · 2024-12-16T05:12:18Z

I think we just need to refactor only Settings inspector controls here and leave Media as it is.

NidhiDhandhukiya74 · 2024-12-20T10:00:02Z

Hello @Mamaduka
I have refractor the settings also for site-logo.

t-hamano

Thanks for the PR!

This PR seems to be expected to refactor only the Settings panel, but it looks like the Media panel has also been refactored. @NidhiDhandhukiya74 Could you check this PR again?

You might also want to address the following:

All controls should be visible by default for now. Add isShownByDefault to the ToolsPanelItem component.
The dropdown needs to be on the left. Add dropdownMenuProps to the ToolsPanel component (Example).

Mamaduka · 2025-01-13T06:04:16Z

I started refactoring media controls to fix some accessibility issues #68621. It might be better to hold off on this change until bug fixes are merged.

t-hamano · 2025-01-18T04:30:58Z

@NidhiDhandhukiya74 Now that #68621 has been merged, could you resolve the conflict for this PR?

NidhiDhandhukiya74 · 2025-02-07T18:51:11Z

Hello @t-hamano

I've made the requested changes:

Refactored only the Settings panel.
Ensured all controls are visible by default using isShownByDefault in ToolsPanelItem.
I’ve also tried using dropdownMenuProps in ToolsPanel to move the dropdown to the left, but I’m not sure if it's correct. Could you please check and let me know if any adjustments are needed?

packages/block-library/src/site-logo/edit.js

Treat false as a valid value for isLink instead of defaulting to true. Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com>

Reset value by updating isLink to its default true. Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com>

t-hamano · 2025-05-26T04:18:40Z

Hi @NidhiDhandhukiya74,

Sorry for the late reply. I think this PR is ready to ship, so could you confirm the following points?

Refresh this PR. This means that merge the latest trunk into this PR, or rebase this PR with trunk.
Update the title and description according to the actual code changes. Because this PR only changes the Settings panel.

…edia-panel

NidhiDhandhukiya74 · 2025-05-30T10:43:38Z

Hi @t-hamano
Thanks for the update! No worries about the delay.

✅ I’ve refreshed the PR by merging the latest trunk into it.
✅ I've also updated the title and description to accurately reflect that this PR only changes the Settings panel.

Let me know if there's anything else you'd like me to update!

t-hamano · 2025-05-30T12:01:11Z

@NidhiDhandhukiya Thanks for the update!

Finally, could you check the following points?

The dropdownMenuProps prop needs to be applied to the ToolsPanel component, not the ToolsPanelItem component.
This PR only changes the Settings panel. The title and description seem to describe the Media panel.

NidhiDhandhukiya74 · 2025-06-06T08:02:35Z

Hi @t-hamano

I have made the changes as requested. The dropdownMenuProps prop is now applied to the ToolsPanel component instead of the ToolsPanelItem. Also, the PR has been updated to reflect the correct panel—Settings panel instead of Media panel.

Thanks for the review!

t-hamano

LGTM!

* refactor site logo media panel * refractor site settings of site logo * added shown by default to toolspanelitem and added dropdownMenuProps * Update packages/block-library/src/site-logo/edit.js Treat false as a valid value for isLink instead of defaulting to true. Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com> * Update packages/block-library/src/site-logo/edit.js Reset value by updating isLink to its default true. Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com> * Migrate Settings panel to ToolsPanel and fix dropdownMenuProps usage --------- Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com> Co-authored-by: NidhiDhandhukiya74 <nidhi.dhandhukiya@multidots.com> Unlinked contributors: NidhiDhandhukiya. Co-authored-by: NidhiDhandhukiya74 <nidhidhandhukiya@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org>

refactor site logo media panel

9c04848

NidhiDhandhukiya74 requested review from ajitbohra and fabiankaegy as code owners December 13, 2024 11:02

github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Dec 13, 2024

fabiankaegy added [Type] Enhancement A suggestion for improvement. [Block] Site Logo Affects the Site Logo Block labels Dec 13, 2024

fabiankaegy linked an issue Dec 13, 2024 that may be closed by this pull request

Refactor "Media" panel of Site Logo block to use ToolsPanel instead of PanelBody #67936

Closed

refractor site settings of site logo

2db9aca

t-hamano reviewed Jan 13, 2025

View reviewed changes

t-hamano mentioned this pull request Jan 20, 2025

Standardize Block Inspector Settings to use ToolsPanel - Tracking Issue #67813

Closed

NidhiDhandhukiya74 added 2 commits February 7, 2025 18:54

resolve merge conflicts

021b67c

added shown by default to toolspanelitem and added dropdownMenuProps

23fc7ff

t-hamano reviewed Feb 10, 2025

View reviewed changes

packages/block-library/src/site-logo/edit.js Outdated Show resolved Hide resolved

packages/block-library/src/site-logo/edit.js Outdated Show resolved Hide resolved

NidhiDhandhukiya74 and others added 2 commits February 10, 2025 10:34

Update packages/block-library/src/site-logo/edit.js

57c7e1d

Treat false as a valid value for isLink instead of defaulting to true. Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com>

Update packages/block-library/src/site-logo/edit.js

3ccd762

Reset value by updating isLink to its default true. Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com>

Merge remote-tracking branch 'origin/trunk' into refactor-site-logo-m…

90b56e9

…edia-panel

NidhiDhandhukiya74 changed the title ~~refactor site logo media panel.~~ Refactor Site Logo "Media" Panel to Use ToolsPanel May 30, 2025

NidhiDhandhukiya added 2 commits June 6, 2025 12:48

Merge branch 'trunk' into refactor-site-logo-media-panel

daa8ed8

Migrate Settings panel to ToolsPanel and fix dropdownMenuProps usage

5e66b20

t-hamano approved these changes Jun 9, 2025

View reviewed changes

t-hamano changed the title ~~Refactor Site Logo "Media" Panel to Use ToolsPanel~~ Refactor Site Logo "Settings" Panel to Use ToolsPanel Jun 9, 2025

t-hamano merged commit 22c55f6 into WordPress:trunk Jun 9, 2025
60 checks passed

github-actions bot added this to the Gutenberg 21.1 milestone Jun 9, 2025

t-hamano mentioned this pull request Jun 9, 2025

Refactor "Media" panel of Site Logo block to use ToolsPanel instead of PanelBody #67936

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Refactor Site Logo "Settings" Panel to Use ToolsPanel #67972

Refactor Site Logo "Settings" Panel to Use ToolsPanel #67972

Uh oh!

NidhiDhandhukiya74 commented Dec 13, 2024 •

edited by t-hamano

Loading

Uh oh!

github-actions bot commented Dec 13, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Dec 13, 2024

Uh oh!

Mamaduka commented Dec 16, 2024

Uh oh!

NidhiDhandhukiya74 commented Dec 20, 2024

Uh oh!

t-hamano left a comment

Uh oh!

Mamaduka commented Jan 13, 2025

Uh oh!

t-hamano commented Jan 18, 2025

Uh oh!

NidhiDhandhukiya74 commented Feb 7, 2025

Uh oh!

Uh oh!

Uh oh!

t-hamano commented May 26, 2025

Uh oh!

NidhiDhandhukiya74 commented May 30, 2025

Uh oh!

t-hamano commented May 30, 2025

Uh oh!

NidhiDhandhukiya74 commented Jun 6, 2025

Uh oh!

t-hamano left a comment

Uh oh!

Uh oh!

Uh oh!

Refactor Site Logo "Settings" Panel to Use ToolsPanel #67972

Refactor Site Logo "Settings" Panel to Use ToolsPanel #67972

Uh oh!

Conversation

NidhiDhandhukiya74 commented Dec 13, 2024 • edited by t-hamano Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What?

Screenshots or screencast

Uh oh!

github-actions bot commented Dec 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Unlinked Accounts

Uh oh!

github-actions bot commented Dec 13, 2024

Uh oh!

Mamaduka commented Dec 16, 2024

Uh oh!

NidhiDhandhukiya74 commented Dec 20, 2024

Uh oh!

t-hamano left a comment

Choose a reason for hiding this comment

Uh oh!

Mamaduka commented Jan 13, 2025

Uh oh!

t-hamano commented Jan 18, 2025

Uh oh!

NidhiDhandhukiya74 commented Feb 7, 2025

Uh oh!

Uh oh!

Uh oh!

t-hamano commented May 26, 2025

Uh oh!

NidhiDhandhukiya74 commented May 30, 2025

Uh oh!

t-hamano commented May 30, 2025

Uh oh!

NidhiDhandhukiya74 commented Jun 6, 2025

Uh oh!

t-hamano left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

NidhiDhandhukiya74 commented Dec 13, 2024 •

edited by t-hamano

Loading

github-actions bot commented Dec 13, 2024 •

edited

Loading