Skip to content

Conversation

im3dabasia
Copy link
Contributor

@im3dabasia im3dabasia commented Dec 13, 2024

Part of #67813
Fixes: #67948

What?

Refactored Navigation Submenu Block code to include ToolsPanel instead of PanelBody.

Screenshots or screencast

Trunk In this PR
Screenshot 2024-12-13 at 4 01 59 PM Screenshot 2024-12-13 at 4 03 05 PM Screenshot 2024-12-13 at 4 03 14 PM

@im3dabasia im3dabasia marked this pull request as ready for review December 13, 2024 10:44
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: im3dabasia <im3dabasia1@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@fabiankaegy fabiankaegy added [Type] Enhancement A suggestion for improvement. [Block] Submenu Affects the Submenu Block - for submenus in navigation labels Dec 13, 2024
Copy link
Member

@fabiankaegy fabiankaegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works as expected :)

CleanShot.2024-12-13.at.23.50.01.mp4

@fabiankaegy fabiankaegy merged commit 84d26fc into WordPress:trunk Dec 13, 2024
70 of 73 checks passed
@github-actions github-actions bot added this to the Gutenberg 20.0 milestone Dec 13, 2024
yogeshbhutkar pushed a commit to yogeshbhutkar/gutenberg that referenced this pull request Dec 18, 2024
…el instead of PanelBody (WordPress#67969)

Co-authored-by: im3dabasia <im3dabasia1@git.wordpress.org>
Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org>
yogeshbhutkar pushed a commit to yogeshbhutkar/gutenberg that referenced this pull request Dec 18, 2024
…el instead of PanelBody (WordPress#67969)

Co-authored-by: im3dabasia <im3dabasia1@git.wordpress.org>
Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Submenu Affects the Submenu Block - for submenus in navigation [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor "Settings" panel of Navigation Submenu block to use ToolsPanel instead of PanelBody
2 participants