Author Block: Refactor Settings panel to use Toolspanel #67965

im3dabasia · 2024-12-13T09:51:22Z

What?

Refactored Author Block code to include ToolsPanel instead of PanelBody.

Screenshots

Trunk	In this PR

github-actions · 2024-12-20T11:54:47Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: im3dabasia <im3dabasia1@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Mamaduka · 2025-05-28T13:02:03Z

@im3dabasia, do you mind rebasing this PR on top of the latest trunk?

im3dabasia · 2025-05-28T13:24:25Z

@Mamaduka , I have merged the latest trunk branch into the current one.

Please check at your convenience and looking forward for your feedback.

Mamaduka

Thanks for refreshing the branch, @im3dabasia!

The refactoring looks good, but it still needs some work.

The ToolsPanel needs useToolsPanelDropdownMenuProps.
The hasValue conditions need to be fixed and correctly represent default values. Otherwise, the freshly inserted block already has values to reset.
The author selection isn't a block-level attribute, but modifies the actual post author; it would be difficult to define what default is and make it resettable. We might have to avoid using ToolsPanelItem for it. @t-hamano, had to make similar changes for a couple of other blocks, here's the recent one #70210.

Screenshot

…tack for styling

packages/block-library/src/post-author/edit.js

Mamaduka · 2025-05-29T16:27:27Z

Thanks for the follow-ups, @im3dabasia! I did a quick test, and I think we're moving in the right direction.

I believe the last item from my previous comment still needs resolution - #67965 (review).

im3dabasia · 2025-05-30T07:32:13Z

I believe the last item from my previous comment still needs resolution - #67965 (review).

Thank you for the feedbacks @Mamaduka .

I think I have handled the last feedback as well, the suggestion was to remove ToolsPanelItem from the Author Selection control, I have rightly done this. Also removing the ToolsPanelItem top level component means that we no longer save attribute which does not exist in the block.json, which is corrected in this commit acd8cac

Please Let me know if I am missing something.

Author Selection Snippet without ToolsPanelItem

{ showAuthorControl && (
    <VStack
	    spacing={ 4 }
	    style={ { gridColumn: '1 / -1' } }
    >
	    { ( showCombobox && (
		    <ComboboxControl
			    __next40pxDefaultSize
			    __nextHasNoMarginBottom
			    label={ __( 'Author' ) }
			    options={ authorOptions }
			    value={ authorId }
			    onChange={ handleSelect }
			    allowReset={ false }
		    />
	    ) ) || (
		    <SelectControl
			    __next40pxDefaultSize
			    __nextHasNoMarginBottom
			    label={ __( 'Author' ) }
			    value={ authorId }
			    options={ authorOptions }
			    onChange={ handleSelect }
		    />
	    ) }
    </VStack>
) }

packages/block-library/src/post-author/edit.js

t-hamano · 2025-06-03T11:47:56Z

packages/block-library/src/post-author/edit.js

+					<ToolsPanelItem
+						label={ __( 'Link author name' ) }
+						isShownByDefault
+						hasValue={ () => isLink !== false }


Suggested change

hasValue={ () => isLink !== false }

hasValue={ () => !! isLink }

@t-hamano , isLink is by default false basis on the block.json, I was wondering if we could simply go for something like this

hasValue={ () => isLink }

There are no hard and fast rules, so I think either approach is fine.

packages/block-library/src/post-author/edit.js

packages/block-library/src/post-author/editor.scss

t-hamano

LGTM 👍

All requested changes have been addressed.

) * refactor: Used ToolsPanel instead of PanelBody * feat: Remove ToolsPanel for the author selection control and added VStack for styling * feat: Add useToolsPanelDropdownMenuProps in the ToolsPanel as a prop * fix: Handle reset menu items properly in hasValue * fix: Improved code quality and showBio handling * chore: avatarSize code quality improvement * fix: Maintain consistency in label for Link Author Name * feat: Remove redudant CSS styles and file for editor.scss * fix: Update hasValue notations for the Avatar and Link controls * fix: Failing e2e, unit test cases due to wrong import Co-authored-by: im3dabasia <im3dabasia1@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org>

refactor: Used ToolsPanel instead of PanelBody

9977c49

im3dabasia changed the title ~~Author Block: Refactor "Settings" panel to use Toolspanel~~ Author Block: Refactor Settings panel to use Toolspanel Dec 13, 2024

fabiankaegy added [Type] Enhancement A suggestion for improvement. [Block] Post Author Affects the Post Author Block labels Dec 13, 2024

im3dabasia marked this pull request as ready for review December 20, 2024 11:54

im3dabasia requested review from ajitbohra and fabiankaegy as code owners December 20, 2024 11:54

t-hamano mentioned this pull request Jan 13, 2025

Standardize Block Inspector Settings to use ToolsPanel - Tracking Issue #67813

Closed

im3dabasia added 2 commits May 28, 2025 18:48

Merge branch 'trunk' into try/refactor-author-block

de679ed

Merge branch 'trunk' into try/refactor-author-block

4011ac3

Mamaduka previously requested changes May 28, 2025

View reviewed changes

im3dabasia added 3 commits May 29, 2025 16:45

feat: Remove ToolsPanel for the author selection control and added VS…

acd8cac

…tack for styling

feat: Add useToolsPanelDropdownMenuProps in the ToolsPanel as a prop

169ee57

fix: Handle reset menu items properly in hasValue

02c3d6c

im3dabasia commented May 29, 2025

View reviewed changes

packages/block-library/src/post-author/edit.js Outdated Show resolved Hide resolved

im3dabasia commented May 29, 2025

View reviewed changes

packages/block-library/src/post-author/edit.js Outdated Show resolved Hide resolved

t-hamano reviewed May 30, 2025

View reviewed changes

im3dabasia added 2 commits June 2, 2025 15:04

fix: Improved code quality and showBio handling

83d611b

chore: avatarSize code quality improvement

fcb90fa

im3dabasia requested a review from t-hamano June 3, 2025 06:38

t-hamano reviewed Jun 3, 2025

View reviewed changes

im3dabasia added 3 commits June 6, 2025 14:29

fix: Maintain consistency in label for Link Author Name

d47e2f5

feat: Remove redudant CSS styles and file for editor.scss

90bd9ee

fix: Update hasValue notations for the Avatar and Link controls

45c4b39

im3dabasia requested a review from t-hamano June 6, 2025 09:10

fix: Failing e2e, unit test cases due to wrong import

756c862

t-hamano approved these changes Jun 9, 2025

View reviewed changes

t-hamano merged commit 9205301 into WordPress:trunk Jun 9, 2025
62 checks passed

github-actions bot added this to the Gutenberg 21.1 milestone Jun 9, 2025

	hasValue={ () => isLink !== false }
	hasValue={ () => !! isLink }

Author Block: Refactor Settings panel to use Toolspanel #67965

Author Block: Refactor Settings panel to use Toolspanel #67965

Uh oh!

Conversation

im3dabasia commented Dec 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What?

Screenshots

Uh oh!

github-actions bot commented Dec 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Mamaduka commented May 28, 2025

Uh oh!

im3dabasia commented May 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Mamaduka left a comment

Choose a reason for hiding this comment

Screenshot

Uh oh!

Uh oh!

Uh oh!

Mamaduka commented May 29, 2025

Uh oh!

im3dabasia commented May 30, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

t-hamano Jun 3, 2025

Choose a reason for hiding this comment

Uh oh!

im3dabasia Jun 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

t-hamano Jun 9, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

t-hamano left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

im3dabasia commented Dec 13, 2024 •

edited

Loading

github-actions bot commented Dec 20, 2024 •

edited

Loading

im3dabasia commented May 28, 2025 •

edited

Loading

im3dabasia Jun 6, 2025 •

edited

Loading