Remove most of the occurrences of the verb toggle. #66371
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
6 tasks
|
Size Change: +20 B (0%) Total Size: 1.81 MB
ℹ️ View Unchanged
|
|
Reminder: Props to @AhmarZaidi for reporting some of the occurrences on #66319 (comment) |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
6 tasks
carolinan
reviewed
Oct 29, 2024
| @@ -412,7 +412,7 @@ export default function PostList( { postType } ) { | |||
| size="compact" | |||
| isPressed={ quickEdit } | |||
| icon={ drawerRight } | |||
| label={ __( 'Toggle details panel' ) } | |||
| label={ __( 'Details panel' ) } | |||
There was a problem hiding this comment.
Does this still need the word "panel"?
There was a problem hiding this comment.
Good point. I just searched for other occurrences of strings that end with panel. Found the following ones:
'Details panel'
'Save panel'
'Open save panel'
'Open %s styles in Styles panel'
'Show or hide the Block settings panel'
'Close panel'
'Open publish panel'
Should we consider them holistically or evaluate on a case by case basis?
There was a problem hiding this comment.
I thought this could be evaluated on case by case because I saw the name and thought this was limited to the data views.
But I found that I don't know where in the interface this is used.
There was a problem hiding this comment.
I found it, it is only visible in the data views when specific layouts are used:
Compared to the two options next to it, which both uses modals / popups, it does open a panel. Not sure if that is valuable information for users.
There was a problem hiding this comment.
Yes, it is worth mentioning that the Gutenberg experiment 'Quick Edit in DataViews' needs to be enabled for this icon button to show. That said, I'd agree this button label should not include the word 'panel' to be consistent with other similar controls that perform the same action e.g. the 'Settings' panel.
carolinan
reviewed
Oct 29, 2024
packages/editor/src/components/global-keyboard-shortcuts/register-shortcuts.js
Show resolved
Hide resolved
carolinan
reviewed
Oct 29, 2024
| ? __( 'Exit Distraction Free' ) | ||
| : __( 'Enter Distraction Free' ), | ||
| ? __( 'Exit Distraction free' ) | ||
| : __( 'Enter Distraction free' ), |
There was a problem hiding this comment.
Should this include the word "mode" like in the actions and for the Spotlight mode?
There was a problem hiding this comment.
Not sure. In the UI it's called 'Distraction free':
There was a problem hiding this comment.
I see.
Then is it a problem that the actions use "mode" ?
https://github.com/WordPress/gutenberg/pull/66371/files#diff-720958d1c802af9bf18a040f83ca28fe8b3ff42b6c1c81566426a2adb970f3e2R844
carolinan
reviewed
Oct 29, 2024
carolinan
reviewed
Oct 29, 2024
carolinan
approved these changes
Oct 29, 2024
c5829dd to
5e0a7af
Compare
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
* Remove most of the occurrences of the verb toggle. * Remove term panel. Co-authored-by: afercia <afercia@git.wordpress.org> Co-authored-by: carolinan <poena@git.wordpress.org> Co-authored-by: mcsf <mcsf@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #66369
What?
Removes the verb 'toggle' from most of the UI.
Why?
The verb
toggleis not well translatable in many languages and should not be used in the UI.It's a well known issue, see #42492 and Trac https://core.trac.wordpress.org/ticket/34753 (November 2015).
How?
Either removes or replaces the verb 'toggle' from translatabel strings.
Note:
I kept two occurrences:
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast