-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Closed
Labels
[Type] BugAn existing feature does not function as intendedAn existing feature does not function as intendedl10nLocalization and translations best practicesLocalization and translations best practices
Description
Description
Similarly to #65983 and #66334
The verb 'toggle' isn't well translatable in many languages and should not be used. See #42492 and similar trac ticket for Core.
Instead of attempting to fix each occurrence at a time, I'd liek to propose to remove all occurrences from the codebase. It would be great to include this best practice in the dev documentation and the design guidelines.
Cc @wordpress/gutenberg-core @WordPress/gutenberg-design
Props to @AhmarZaidi for reporting some of the occurrences on #66319 (comment)
Step-by-step reproduction instructions
- Run a regex search through the codebase for the verb
toggle
inside translatable string. Roughly, something like\( '.*toggle.*' \)
should be enough.
Screenshots, screen recording, code snippet
No response
Environment info
No response
Please confirm that you have searched existing issues in the repo.
- Yes
Please confirm that you have tested with all plugins deactivated except Gutenberg.
- Yes
Please confirm which theme type you used for testing.
- Block
- Classic
- Hybrid (e.g. classic with theme.json)
- Not sure
AhmarZaidi
Metadata
Metadata
Assignees
Labels
[Type] BugAn existing feature does not function as intendedAn existing feature does not function as intendedl10nLocalization and translations best practicesLocalization and translations best practices