Add $schema and use Gutenberg classes #99
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This works as expected in every case except when trying to create a child theme. It generates a zip that won't open (it works on trunk, but fails on this branch) I'm seeing this: |
|
Thanks @MaggieCabrera, I added a commit to fix that... |
MaggieCabrera
approved these changes
Aug 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the $schema key when overwriting and exporting themes. It also uses the WP_Theme_JSON_Gutenberg class if it's available, so that the latest features of the plugin are included.
To test, try exporting/overwriting a block theme and check that the $schema key still exists. Also check that button elements aren't wiped. You can see an example here: Automattic/themes#5708
Fixes #81