app/vmselect/netstorage: do not retry "cannot obtain connection from the pool" errors #9484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
85ef3b0 to
0b3f3d8
Compare
…the pool" errors Currently, all errors that occur during the handshake and dial phases (except for timeouts) are retried in execOnConnWithPossibleRetry. However, such errors typically result from network issues or CPU exhaustion on the storage side. In both cases, retrying is unlikely to succeed and may instead contribute to additional, unnecessary load on the system. This PR disables retries for all errors encountered during the handshake and dial process. The goal is to avoid redundant retry attempts in scenarios where they are unlikely to help and may worsen the underlying problem.
0b3f3d8 to
3878cbc
Compare
makasim
added a commit
that referenced
this pull request
Jul 28, 2025
…the pool" errors (#9484) Currently, all errors that occur during the handshake and dial phases (except for timeouts) are retried in [execOnConnWithPossibleRetry](https://github.com/VictoriaMetrics/VictoriaMetrics/blob/0c4062b7276cecb3345197f6aa1181cfab1f2f00/app/vmselect/netstorage/netstorage.go#L2431). However, such errors typically result from network issues or CPU exhaustion on the storage side. In both cases, retrying is unlikely to succeed and may instead contribute to additional, unnecessary load on the system. This PR disables retries for all errors encountered during the handshake and dial process. The goal is to avoid redundant retry attempts in scenarios where they are unlikely to help and may worsen the underlying problem. Related to #9345 The following checks are **mandatory**: - [ ] My change adheres to [VictoriaMetrics contributing guidelines](https://docs.victoriametrics.com/victoriametrics/contributing/#pull-request-checklist). - [ ] My change adheres to [VictoriaMetrics development goals](https://docs.victoriametrics.com/victoriametrics/goals/).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
Currently, all errors that occur during the handshake and dial phases (except for timeouts) are retried in execOnConnWithPossibleRetry. However, such errors typically result from network issues or CPU exhaustion on the storage side. In both cases, retrying is unlikely to succeed and may instead contribute to additional, unnecessary load on the system.
This PR disables retries for all errors encountered during the handshake and dial process. The goal is to avoid redundant retry attempts in scenarios where they are unlikely to help and may worsen the underlying problem.
Related to #9345
Checklist
The following checks are mandatory: