lib/storage:fix Less Method in tagFilter Struct #9127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d899117 to
8010151
Compare
|
Also, there's an empty line at the end of tag_filters_test.go. Please remove it and try testing locally by |
e2548be to
b6607c2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9127 +/- ##
==========================================
- Coverage 60.37% 58.59% -1.78%
==========================================
Files 411 700 +289
Lines 76609 120643 +44034
==========================================
+ Hits 46253 70693 +24440
- Misses 27794 46430 +18636
- Partials 2562 3520 +958 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Thanks for the reminder! I've added a changelog and cleaned up the extra blank lines in tag_filters_test.go. Is there anything else I should take care of? |
makasim
reviewed
Jun 9, 2025
makasim
approved these changes
Jun 10, 2025
makasim
reviewed
Jun 10, 2025
valyala
approved these changes
Jun 10, 2025
|
@sforests , thanks for the fix! |
valyala
pushed a commit
that referenced
this pull request
Jun 10, 2025
### Describe Your Changes This pull request addresses a bug in the Less method of the tagFilter struct. The original implementation incorrectly assigned the value of isCompositeB by calling tf.isComposite() instead of other.isComposite(). This caused both isCompositeA and isCompositeB to always have the same value, leading to incorrect comparisons when determining the order of tagFilter instances. ### Checklist The following checks are **mandatory**: - [x] My change adheres to [VictoriaMetrics contributing guidelines](https://docs.victoriametrics.com/victoriametrics/contributing/#pull-request-checklist). --------- Co-authored-by: Zhu Jiekun <jiekun@victoriametrics.com>
MatthiasGrandl
pushed a commit
to croit/VictoriaMetrics
that referenced
this pull request
Jun 12, 2025
### Describe Your Changes This pull request addresses a bug in the Less method of the tagFilter struct. The original implementation incorrectly assigned the value of isCompositeB by calling tf.isComposite() instead of other.isComposite(). This caused both isCompositeA and isCompositeB to always have the same value, leading to incorrect comparisons when determining the order of tagFilter instances. ### Checklist The following checks are **mandatory**: - [x] My change adheres to [VictoriaMetrics contributing guidelines](https://docs.victoriametrics.com/victoriametrics/contributing/#pull-request-checklist). --------- Co-authored-by: Zhu Jiekun <jiekun@victoriametrics.com>
chocholom
pushed a commit
to chocholom/VictoriaMetrics
that referenced
this pull request
Jun 12, 2025
### Describe Your Changes This pull request addresses a bug in the Less method of the tagFilter struct. The original implementation incorrectly assigned the value of isCompositeB by calling tf.isComposite() instead of other.isComposite(). This caused both isCompositeA and isCompositeB to always have the same value, leading to incorrect comparisons when determining the order of tagFilter instances. ### Checklist The following checks are **mandatory**: - [x] My change adheres to [VictoriaMetrics contributing guidelines](https://docs.victoriametrics.com/victoriametrics/contributing/#pull-request-checklist). --------- Co-authored-by: Zhu Jiekun <jiekun@victoriametrics.com>
truepele
pushed a commit
to truepele/VictoriaMetrics
that referenced
this pull request
Jun 21, 2025
### Describe Your Changes This pull request addresses a bug in the Less method of the tagFilter struct. The original implementation incorrectly assigned the value of isCompositeB by calling tf.isComposite() instead of other.isComposite(). This caused both isCompositeA and isCompositeB to always have the same value, leading to incorrect comparisons when determining the order of tagFilter instances. ### Checklist The following checks are **mandatory**: - [x] My change adheres to [VictoriaMetrics contributing guidelines](https://docs.victoriametrics.com/victoriametrics/contributing/#pull-request-checklist). --------- Co-authored-by: Zhu Jiekun <jiekun@victoriametrics.com>
truepele
pushed a commit
to truepele/VictoriaMetrics
that referenced
this pull request
Jun 21, 2025
### Describe Your Changes This pull request addresses a bug in the Less method of the tagFilter struct. The original implementation incorrectly assigned the value of isCompositeB by calling tf.isComposite() instead of other.isComposite(). This caused both isCompositeA and isCompositeB to always have the same value, leading to incorrect comparisons when determining the order of tagFilter instances. ### Checklist The following checks are **mandatory**: - [x] My change adheres to [VictoriaMetrics contributing guidelines](https://docs.victoriametrics.com/victoriametrics/contributing/#pull-request-checklist). --------- Co-authored-by: Zhu Jiekun <jiekun@victoriametrics.com>
|
The fix has been included to v1.120.0 release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
This pull request addresses a bug in the Less method of the tagFilter struct. The original implementation incorrectly assigned the value of isCompositeB by calling tf.isComposite() instead of other.isComposite(). This caused both isCompositeA and isCompositeB to always have the same value, leading to incorrect comparisons when determining the order of tagFilter instances.
Checklist
The following checks are mandatory: