refactor: [Python] 脱Pydanticを見越したリファクタ #1029
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8639245 to
a1ec8f3
Compare
a1ec8f3 to
cb8a17a
Compare
|
0.16のリリースには不要なのでドキュメントの完成が先、という認識です！ |
|
↑のコメントですが、release-0.16ブランチを作るならそうでもないと思ったのでちょっと0.16 issueの方にコメントしました！ |
Hiroshiba
approved these changes
Mar 7, 2025
| from_dataclass(ob) | ||
| } | ||
|
|
||
| pub(crate) fn from_accent_phrases(ob: &Bound<'_, PyAny>) -> PyResult<Vec<AccentPhrase>> { |
There was a problem hiding this comment.
（ただのコメントです）
これ、複数形じゃないfrom_accent_phraseを作る方が一般的かなと思いましたが、Vecを返すコードにしておくと結構行数が減るぽいので、まあこちらでも良いのかなと思いました！
qryxip
added a commit
that referenced
this pull request
Mar 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
#960 を見越し、引数と返り値の形に関してリファクタを行う。
関連 Issue
その他
こないだDiscordで言ってた間違えて
git restoreで吹っ飛ばしたやつから、記憶をベースにもう一度よく考えた上、リファクタ部分を抽出したものです。