Skip to content

file pathをutf8対応した(windows) #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 27, 2022
Merged

file pathをutf8対応した(windows) #7

merged 2 commits into from
Jul 27, 2022

Conversation

qwerty2501
Copy link

@qwerty2501 qwerty2501 mentioned this pull request Jul 27, 2022
Merged
@qwerty2501
Copy link
Author

default branchが 1.11 になってますがいいんでしょうか？

@PickledChair
Copy link
Member

以下の部分もコメントアウトを解除する必要があると思いました！

open_jtalk/src/mecab/src/common.h

Lines 147 to 154 in dc5c4fa

/* for Open JTalk
#if defined(_WIN32) && !defined(__CYGWIN__)
#define WPATH(path) (MeCab::Utf8ToWide(path).c_str())
#else
#define WPATH(path) (path)
#endif
*/
#define WPATH(path) (path)

@qwerty2501
Copy link
Author

@PickledChair 解除しました

@Hiroshiba
Copy link
Member

default branchが 1.11 になってます

たしかこれで大丈夫な運用なはず･･･！

Hiroshiba
Hiroshiba approved these changes Jul 27, 2022
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！！

@Hiroshiba Hiroshiba merged commit acd0cc6 into VOICEVOX:1.11 Jul 27, 2022
@Hiroshiba Hiroshiba mentioned this pull request Jul 27, 2022
Closed
@Hiroshiba
Copy link
Member

pyopenjtlak側の設定が必要なことを忘れないようにissue作っておきました。

@qwerty2501 qwerty2501 deleted the feature/utf8-for-windows branch July 27, 2022 23:44
Hiroshiba pushed a commit that referenced this pull request Apr 1, 2025
@r9y9
Updates for open_jtalk 1.11 (#7)
ce06fc5 
* Update code for open jtalk 1.11

based on open_jtalk-1.11.tar.gz
https://sourceforge.net/projects/open-jtalk/

* Update version in CMakeLists.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hiroshiba Hiroshiba Hiroshiba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qwerty2501 @PickledChair @Hiroshiba