Skip to content

POCA Attention will use h_size for embedding size and not 128 #5281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 19, 2021
Merged

POCA Attention will use h_size for embedding size and not 128 #5281

merged 1 commit into from
Apr 19, 2021

Conversation

vincentpierre
Copy link
Contributor

@vincentpierre vincentpierre commented Apr 16, 2021 •
edited
Loading

Proposed change(s)

[Need to cherry pick to release_17_branch after merge]

Reverting the change that made POCA attention embedding size 128. It will be using the h_size instead.

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

@vincentpierre vincentpierre requested a review from ervteng April 16, 2021 20:48
@vincentpierre vincentpierre self-assigned this Apr 16, 2021
@vincentpierre vincentpierre merged commit 8c01b76 into main Apr 19, 2021
@delete-merged-branch delete-merged-branch bot deleted the make-poca-attn-use-h branch April 19, 2021 16:06
vincentpierre added a commit that referenced this pull request Apr 19, 2021
@vincentpierre
POCA Attention will use h_size for embedding size and not 128 (#5281)
e429fd3
@vincentpierre vincentpierre mentioned this pull request Apr 19, 2021
Merged
10 tasks
vincentpierre added a commit that referenced this pull request Apr 19, 2021
@vincentpierre
POCA Attention will use h_size for embedding size and not 128 (#5281) (…
af761d1 
…#5287)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@ervteng ervteng ervteng approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@vincentpierre vincentpierre

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vincentpierre @ervteng