Implement multiple actions (double tap, triple tap) #349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renamed old action and longAction to legacy
|
LGTM too. Just small request, please, could you add inforation and to Readme as well? How to use it for people :) |
Of course! |
|
@Toxblh and @ReDetection could you please review latest changes? I updated README and slightly changed the code to support multiple actions for the same trigger |
tomeresk
pushed a commit
to tomeresk/MTMR
that referenced
this pull request
Jul 16, 2021
* Implement double tap and new actions array in config * Update native widgets to use new actions parameter * Refactor new actions parameter moving it to main definition Renamed old action and longAction to legacy * Fix tests * Remove unused code * Readd test for legacyAction * Implement triple tap * Add new actions explanation * Add support for multiple actions and same trigger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements:
actionsparameter in config. Example:{ "type": "staticButton", "title": "test", "actions": [ { "trigger": "singleTap", "action": "shellScript", "executablePath": "/usr/bin/say", "shellArguments": ["Single"] }, { "trigger": "doubleTap", "action": "shellScript", "executablePath": "/usr/bin/say", "shellArguments": ["Double"] }, { "trigger": "longTap", "action": "shellScript", "executablePath": "/usr/bin/say", "shellArguments": ["Long"] } ] }actionandlongActionworks normally, i retained the legacy code to not break compatibility.