Skip to content

Release 23.4.1 | Routing patch | November'24 release | +semver: patch #2215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

@raman-m raman-m self-assigned this Nov 22, 2024
@raman-m raman-m added release Pre/Release (minor, major) Nov'24 November 2024 release labels Nov 22, 2024
@raman-m raman-m added this to the November'24 milestone Nov 22, 2024
@ggnaegi ggnaegi merged commit 234b6b8 into release/23.4 Nov 22, 2024
1 check passed
@raman-m
Copy link
Member Author

raman-m commented Nov 22, 2024

@ggnaegi What are you doing here, man? 🤯 😑
Why did you merge the PR if #2213 is still open?
It is preferable to read code review messages rather than pressing buttons throughout the repository.

@raman-m
Copy link
Member Author

raman-m commented Nov 22, 2024

There was no critical incident with the merging process because it not the main branch 🤕
I will consistently target release PRs to release branches to allow you @ggnaegi to press magic buttons 😂

FYI When I request approval from the team, I will inform everyone that I am planning to release soon, provided all tasks are completed. Your approval indicates that you have finished all tasks and that it is acceptable to release the current and fixes. If you have overlooked something, please feel free to notify me as the repository maintainer so that I can address any.

Not right buttons in wrong PR, @ggnaegi

Merging to release branch not actually triggers a release 😛

@ggnaegi
Copy link
Member

ggnaegi commented Nov 22, 2024

@raman-m uuuups

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Nov'24 November 2024 release release Pre/Release (minor, major)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants