#1305 Populate RateLimiting headers in the original HttpContext response accessed via IHttpContextAccessor
#1307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
finnaly |
|
+1 to get this merged. This is stopping me being able to update a project to net6.0 + Ocelot v18 |
This comment was marked as off-topic.
This comment was marked as off-topic.
|
+1 We need this fix as well |
72da5b1 to
1060ef9
Compare
|
The feature branch has been rebased onto ThreeMammals:develop! We can start the code review... |
This comment was marked as off-topic.
This comment was marked as off-topic.
|
@jackletter commented on Oct 24, 2020:
Is this a result of code review (testing)? P.S. Don't write non-English messages please! |
wast
reviewed
Aug 2, 2023
test/Ocelot.UnitTests/RateLimit/ClientRateLimitMiddlewareTests.cs
Outdated
Show resolved
Hide resolved
wast
approved these changes
Aug 2, 2023
53fbcd2 to
eaff1d9
Compare
HttpContext response using IHttpContextAccessor
HttpContext response using IHttpContextAccessorHttpContext response accessed via IHttpContextAccessor.
HttpContext response accessed via IHttpContextAccessor.HttpContext response accessed via IHttpContextAccessor
Hang in there, Gary! |
Dev Complete and reviewer is offline
yjorayev
pushed a commit
to yjorayev/Ocelot
that referenced
this pull request
Nov 13, 2024
…Context` response accessed via `IHttpContextAccessor` (ThreeMammals#1307) * set rate limiting headers on the proper httpcontext * fix Retry-After header * merge fix * refactor of ClientRateLimitTests * merge fix * Fix build after rebasing * EOL: test/Ocelot.AcceptanceTests/Steps.cs * Add `RateLimitingSteps` * code review by @raman-m * Inject IHttpContextAccessor, not IServiceProvider * Ocelot's rate-limiting headers have become legacy * Headers definition life hack * A good StackOverflow link --------- Co-authored-by: Jolanta Łukawska <jolanta.lukawska@outlook.com> Co-authored-by: Raman Maksimchuk <dotnet044@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1305
"DisableRateLimitHeaders": falseis not showingX-Rate-LimitandRetry-Afterheaders in response #1305Proposed Changes
HttpContextand not the original one that is returned with a response. The fix is that the rate limiting headers are set for the originalHttpContextreturned byHttpContextAccessor.