fix(models): correct the erroneous local model filename when the mode… #4302
Conversation
…l has multiple gguf partitions
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue with the local model filename resolution when handling models with multiple gguf partitions. The changes include:
- Adding an import for fs to support file system operations.
- Modifying resolve_model_path to use a new helper function get_model_entry_path.
- Introducing get_model_entry_path to locate the model entry file based on a specified prefix.
| // will look for the file with the prefix "00001-of-" | ||
| pub fn get_model_entry_path(path: &PathBuf) -> Option<PathBuf> { | ||
| for entry in fs::read_dir(path).ok()? { | ||
| let entry = entry.expect("Error reading directory entry"); |
There was a problem hiding this comment.
Using expect here may cause a panic if directory entry reading fails. Consider handling the error gracefully (e.g., by propagating the error or logging it) to prevent unexpected crashes.
| let entry = entry.expect("Error reading directory entry"); | |
| let entry = entry.ok()?; // Propagate error gracefully |
Copilot uses AI. Check for mistakes.
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #4302 +/- ##
==========================================
- Coverage 55.37% 55.33% -0.04%
==========================================
Files 238 238
Lines 30276 30294 +18
==========================================
Hits 16764 16764
- Misses 13512 13530 +18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…l has multiple gguf partitions (#4302)
…l has multiple gguf partitions
fix #4298