Fix custom profiles added/removed each other run #8179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Dima Buzdyk <46728448+buzzhuzz@users.noreply.github.com>
SoftFever
requested changes
Jan 25, 2025
| @@ -1090,17 +1090,21 @@ void PresetUpdater::priv::check_installed_vendor_profiles() const | |||
| std::string vendor_name = path.filename().string(); | |||
| // Remove the .json suffix. | |||
| vendor_name.erase(vendor_name.size() - 5); | |||
| if (bundles.find(vendor_name) != bundles.end())continue; | |||
|
|
|||
| const auto is_vendor_enabled = (vendor_name == PresetBundle::ORCA_DEFAULT_BUNDLE) // always update configs from resource to vendor for ORCA_DEFAULT_BUNDLE | |||
GiacomoGuaresi
pushed a commit
to gingeradditive/OrcaSlicer
that referenced
this pull request
Feb 8, 2025
* Avoid updating same vendor multiple times and unnecessary version checks * Fix custom profiles added/removed each other run (SoftFever#8094) Co-authored-by: Dima Buzdyk <46728448+buzzhuzz@users.noreply.github.com> --------- Co-authored-by: Dima Buzdyk <46728448+buzzhuzz@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #8094
Replace #8102
Thanks @buzzhuzz for the initial investigation and PR