-
Notifications
You must be signed in to change notification settings - Fork 296
Remove setup.py develop
command
#6424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6424 +/- ##
=======================================
Coverage 89.80% 89.80%
=======================================
Files 90 90
Lines 23752 23752
Branches 4418 4418
=======================================
Hits 21331 21331
Misses 1672 1672
Partials 749 749 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I encountered a problem trying to build scitools-iris with setuptools 80.0 today :
So I'm interested by a new release including this fix. |
@thebaptiste thank you, it hadn't occurred to me that this also affects users in addition to developers. We will certainly need to discuss a patch release in the near future. |
⏱️ Performance Benchmark Report: e43869bPerformance shifts
Full benchmark results
Generated by GHA run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @trexfeathers, LGTM!
⏱️ Performance Benchmark Report: a2ddfe5Performance shifts
Full benchmark results
Generated by GHA run |
* Remove setup.py develop command. * Protect from setuptools>=80 incompatibility. * Relocate What's New entry.
🚀 Pull Request
Description
This is deprecated behaviour and can easily be achieved using
pip install -e .
instead.More info
setuptools
commandsConsult Iris pull request check list
Add any of the below labels to trigger actions on this PR: