Skip to content

Conversation

pp-mo
Copy link
Member

@pp-mo pp-mo commented Aug 31, 2023

I'm unclear whether these changes folllow the correct form, but I suspect anyway that the existing format where it says "doi = {10.5281/zenodo.7386117}" is possibly wrong : this is not a complete valid url.

TBD
UPDATE it is a doi, should not be a url (!)

@pp-mo pp-mo mentioned this pull request Aug 31, 2023
2 tasks
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b7c3f68) 89.37% compared to head (1ca160e) 89.37%.

Additional details and impacted files
@@           Coverage Diff           @@
##           v3.7.x    #5453   +/-   ##
=======================================
  Coverage   89.37%   89.37%           
=======================================
  Files          89       89           
  Lines       22443    22443           
  Branches     5381     5381           
=======================================
  Hits        20058    20058           
  Misses       1639     1639           
  Partials      746      746           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@trexfeathers
Copy link
Contributor

#5324 (comment)

@pp-mo
Copy link
Member Author

pp-mo commented Sep 6, 2023

@SciTools/peloton Connects to #5161 ?
We are in the process, there, of deciding how to manage the generic/per-version citation links + how we would reference them.
Either we will be editing something every release, or maybe not !

revert conversion to url -- it should be a bare DOI
@trexfeathers trexfeathers merged commit 932fd93 into SciTools:v3.7.x Dec 7, 2023
tkknight added a commit to tkknight/iris that referenced this pull request Dec 13, 2023
* main:
  Adopt inital noop ruff linter (SciTools#5623)
  Update links to https (SciTools#5621)
  Bump actions/stale from 8 to 9 (SciTools#5616)
  Faster and simpler iris.util.array_equal (SciTools#5610)
  Updated environment lockfiles (SciTools#5608)
  Bump actions/setup-python from 4 to 5 (SciTools#5614)
  Possible citation updates -- not clear whether appropriate. (SciTools#5453)
  Whats new updates for v3.7.0 . (SciTools#5451)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants