Fix handling of PosixPath in cartopy.io fh_getter function #2500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fh_getter fails when fh is a PosixPath because it attempts at checking filename, which has not been initialized. Fix: Initialize filename to None
|
A very tiny fix in fh_getter for cartopy.io. |
dopplershift
approved these changes
Feb 19, 2025
|
I like the fix, I'm wondering if we can add a test. What were you doing to trigger this error in the first place? |
|
Please update the commit message/PR title to be clearer about the change. |
|
Done. Let me know if this is ok |
I am not sure. I am using cartopy to plot SRTM data. I think this error shows up with recent versions of Python (12 and 13 for sure). It was not failing with 3.8. Anyway, the variable filename was not initialized in the first place, so that should fix it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
fh_getter fails when fh is a PosixPath because it attempts at checking filename, which has not been initialized.
Fix
Initialize filename to None
Implications
Minimal