Measurement +=, -=, *=, /= #1162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1162 +/- ##
==========================================
+ Coverage 95.87% 95.89% +0.01%
==========================================
Files 107 107
Lines 3951 3967 +16
==========================================
+ Hits 3788 3804 +16
Misses 163 163
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Generated by 🚫 Danger |
Co-authored-by: Guy Kogus <guy.kogus@gmail.com>
Co-authored-by: Guy Kogus <guy.kogus@gmail.com>
Co-authored-by: Guy Kogus <guy.kogus@gmail.com>
Co-authored-by: Guy Kogus <guy.kogus@gmail.com>
Co-authored-by: Guy Kogus <guy.kogus@gmail.com>
guykogus
requested changes
Dec 30, 2023
| /// - Parameters: | ||
| /// - lhs: The first value to add. | ||
| /// - rhs: The second value to add. | ||
| static func += (lhs: inout Measurement<UnitType>, rhs: Measurement<UnitType>) { |
There was a problem hiding this comment.
Isn't <UnitType> assumed? If so, remove for all functions.
Suggested change
| static func += (lhs: inout Measurement<UnitType>, rhs: Measurement<UnitType>) { | |
| static func += (lhs: inout Measurement, rhs: Measurement) { |
guykogus
approved these changes
Dec 31, 2023
RomanPodymov
added a commit
to RomanPodymov/RomanPodymov
that referenced
this pull request
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀
Hello.
Thank you for SwifterSwift.
Checklist
@availableif not.