Skip to content

Conversation

djbe
Copy link
Member

@djbe djbe commented Jun 21, 2020

Fixes #719.

Reverts #703.

@djbe djbe added this to the 6.2.1 milestone Jun 21, 2020
@SwiftGen-Eve
Copy link

Hey 👋 I'm Eve, the friendly bot watching over SwiftGen 🤖

Thanks a lot for your contribution!


Seems like everything is in order 👍 You did a good job here! 🤝

Generated by 🚫 Danger

@AliSoftware
Copy link
Collaborator

I think it should be possible to still activate code coverage for debug builds, but disable it for release builds (we use release config for our GH/CP/HB releases)?

@djbe
Copy link
Member Author

djbe commented Jun 22, 2020

@AliSoftware note that this is at the scheme level, not the config level, so I don't think that's possible.

@AliSoftware
Copy link
Collaborator

@AliSoftware note that this is at the scheme level, not the config level, so I don't think that's possible.

Right. I was more thinking about using the right xcodebuild flag when compiling via rake to disable code coverage there during release 🤷🏻

@djbe
Copy link
Member Author

djbe commented Jun 22, 2020

Ah, from a quick search, that would maybe be -enableCodeCoverage NO. Will have to test that.

@djbe
Copy link
Member Author

djbe commented Jun 22, 2020

So, that flag doesn't work:

The flag -enableCodeCoverage is only supported when testing.

I've also tried these to no avail:

CLANG_ENABLE_CODE_COVERAGE=NO GCC_INSTRUMENT_PROGRAM_FLOW_ARCS=NO

Can't seem to find much (anything) about disabling this from CLI.

@AliSoftware
Copy link
Collaborator

Ok, let's disable it completely then.

@djbe djbe merged commit 3352714 into develop Jun 23, 2020
@djbe djbe deleted the fix/revert-code-coverage branch June 23, 2020 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants