Enable code coverage #trivial #703
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey 👋 I'm Eve, the friendly bot watching over SwiftGen 🤖 Thanks a lot for your contribution! Seems like everything is in order 👍 You did a good job here! 🤝 Generated by 🚫 Danger |
AliSoftware
approved these changes
May 27, 2020
There was a problem hiding this comment.
I'm ok with that change but wondering if that will work as expected, given the nature of our tests?
Especially I'm thinking of the fact that we test different layers:
- The code of SwiftGenKit itself (classical Unit Tests)
- The generated contexts, comparing their YAML serialisation with a file on disk serving as baseline
- The generated text (generally swift code) generated by the built-in templates, comparing the generated output with fixtures on disk too
Will code coverage be relevant enough for the last 2 type of tests? 🤷
In any case I don't see any drawbacks in activating it, so let's merge this; just not sure if the interpretation of the coverage result will always be relevant for all cases is all
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
developbranch (gitflow)developas the "base" branch for this Pull Request I'm about to createCHANGELOG.mdfile to explain my changes and credit myself(or added
#trivialto the PR title if I think it doesn't warrant a mention in the CHANGELOG)This makes it way easier for me to know that the unit tests are testing the code paths I'm touching