feat: impl health checker and init data collector #1077
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the health check functionality and introduces a new collector upload service. Key changes include:
- Removal of the deprecated gRPC health check proto and corresponding Go implementations.
- Addition of new proto definitions and generated code for the collector service.
- Updating service registration in the main application to use the official gRPC health check server and the new collector service.
Reviewed Changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| swanlab/proto/core/health/v1/health_service.proto | Updated health check proto with new package and additional RPC methods (Check, List, Watch) and removed deprecated Python stubs. |
| swanlab/proto/core/collector/v1/* | Introduced new proto, Python stubs, and Go generated files for the collector service. |
| script/build_proto.py | Updated build script to generate collector service protos instead of health service protos. |
| core/internal/service/* | Removed health service implementation and added new collector service implementation. |
| core/cmd/core/core.go | Refactored service registration to use grpc_health and register the collector service. |
| core/go.mod | Updated dependency order with explicit golang.org/x/net dependency. |
SAKURA-CAT
added a commit
that referenced
this pull request
Jun 15, 2025
* feat: init go project (#1064) * fix: license use symlink (#1067) * Feature/protobuf: hello-word (#1074) * feat: init go project (#1064) * feat: add proto and grpc * feat: add proto build script * fix: golangci lint * feat: support auto or specify select port * chore: license * chore: add .golangci.yml * fix: use log/slog instead of log * chore: del core vendor --------- Co-authored-by: Kang Li <79990647+SAKURA-CAT@users.noreply.github.com> * feat: impl health checker and init data collector (#1077) * feat: impl health checker and init data collector * chore: change module name --------- Co-authored-by: KAAANG <79990647+SAKURA-CAT@users.noreply.github.com> * Feat/record proto and column parser (#1091) Co-authored-by: kaikai <2837968358@qq.com> * fix: import module and typo --------- Co-authored-by: Kaikai <98205900+Kaikaikaifang@users.noreply.github.com> Co-authored-by: kaikai <2837968358@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description