feat: leveldb #1034
Merged
feat: leveldb #1034
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a LevelDB‐style DataStore for durable logging and integrates it into the existing backup handler, replacing plain-text file writes with a structured, CRC‐protected format. Tests for basic write/scan functionality are also added.
- Implement
DataStoreusing LevelDB log format, including CRC32 integrity checks - Rename model serialization methods (
to_backup→to_record,from_backup→from_record) and update handler calls - Update
BackupHandlerto useDataStoreinstead of direct file I/O and add unit tests
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| test/unit/log/backup/test_datastore.py | Add basic write/read tests for new DataStore implementation |
| swanlab/log/backup/models.py | Rename serialization methods to to_record/from_record and append newline |
| swanlab/log/backup/handler.py | Swap raw file handle for DataStore, update method calls |
| swanlab/log/backup/datastore.py | New DataStore class implementing LevelDB log format with CRC |
| swanlab/log/backup/init.py | Update import path for handler |
| swanlab/data/callbacker/backup.py | Incorrect @file annotation name changed to crypto.py |
| swanlab/cli/commands/sync/init.py | Add new sync command module header |
Comments suppressed due to low confidence (3)
swanlab/log/backup/handler.py:76
- [nitpick] The attribute name
fis too generic now that it holds aDataStore; consider renaming it tostoreordatastorefor clarity.
self.f = DataStore()
swanlab/data/callbacker/backup.py:3
- The
@fileannotation is set tocrypto.pybut the filename is stillbackup.py; please correct the annotation to match the file name.
@file: crypto.py
swanlab/log/backup/datastore.py:32
- [nitpick] Function name
strtobytesdoesn't follow standard snake_case naming; consider renaming tostr_to_bytes(andbytes_to_str).
def strtobytes(x):
SAKURA-CAT
added a commit
that referenced
this pull request
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
借鉴 W&B 的本地日志保存方案，使用 Google 的 LevelDB 协议保存持久化数据并实现完整性校验，防止数据损坏和篡改