Skip to content

chore: standardize format of BUILD overrides #5948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 31, 2023
Merged

chore: standardize format of BUILD overrides #5948

merged 2 commits into from
Mar 31, 2023

Conversation

cognifloyd
Copy link
Member

Quick/minor reformat of some BUILD files.

I like to use dict() under overrides so that syntax highlighting looks similar to a regular target.

So, use this

python_sources(
    overrides={
        "foobar.py": dict(
            dependencies=[...],
        ),
    },
)

instead of this

python_sources(
    overrides={
        "foobar.py": {
            "dependencies": [...],
        },
    },
)

@cognifloyd cognifloyd added this to the pants milestone Mar 31, 2023
@cognifloyd cognifloyd requested review from winem, arm4b, nzlosh, rush-skills, amanda11 and a team March 31, 2023 02:53
@cognifloyd cognifloyd self-assigned this Mar 31, 2023
@pull-request-size pull-request-size bot added the size/M PR that changes 30-99 lines. Good size to review. label Mar 31, 2023
@cognifloyd cognifloyd mentioned this pull request Mar 31, 2023
Merged
@cognifloyd cognifloyd merged commit f35c1a6 into master Mar 31, 2023
@cognifloyd cognifloyd deleted the standardize-overrides-syntax branch March 31, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nzlosh nzlosh nzlosh approved these changes

@amanda11 amanda11 amanda11 approved these changes

@winem winem Awaiting requested review from winem

@arm4b arm4b Awaiting requested review from arm4b

@rush-skills rush-skills Awaiting requested review from rush-skills

Assignees

@cognifloyd cognifloyd

Labels
pantsbuild refactor size/M PR that changes 30-99 lines. Good size to review.
Projects
None yet
Milestone
pants
Development

Successfully merging this pull request may close these issues.
3 participants
@cognifloyd @nzlosh @amanda11