Migrate RC SharedPreferences data to a separate file #2621
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonidero
commented
Aug 21, 2025
| @@ -30,12 +28,6 @@ internal class DiagnosticsSynchronizer( | |||
|
|
|||
| @VisibleForTesting(otherwise = VisibleForTesting.PRIVATE) | |||
| const val MAX_EVENTS_TO_SYNC_PER_REQUEST: Int = 200 | |||
|
|
|||
| fun initializeSharedPreferences(context: Context): SharedPreferences = | |||
There was a problem hiding this comment.
This was unused, so I took the chance to delete it. I think it might be worth moving all the shared preferences handling to the new SharedPreferencesManager... but didn't want to overcomplicate this PR.
tonidero
commented
Aug 21, 2025
| editor.putFloat(key, value) | ||
| true | ||
| } | ||
| is Set<*> -> { |
There was a problem hiding this comment.
These are the only types of data that we store in the shared preferences files (we actually don't use booleans/ints/floats... but I thought it might be good to add just in case.
purchases/src/main/kotlin/com/revenuecat/purchases/common/SharedPreferencesManager.kt
Outdated
Show resolved
Hide resolved
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2621 +/- ##
==========================================
+ Coverage 78.41% 78.47% +0.05%
==========================================
Files 301 302 +1
Lines 11241 11303 +62
Branches 1561 1571 +10
==========================================
+ Hits 8815 8870 +55
- Misses 1740 1745 +5
- Partials 686 688 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JayShortway
reviewed
Aug 22, 2025
purchases/src/main/kotlin/com/revenuecat/purchases/PurchasesOrchestrator.kt
Outdated
Show resolved
Hide resolved
purchases/src/main/kotlin/com/revenuecat/purchases/common/SharedPreferencesManager.kt
Outdated
Show resolved
Hide resolved
purchases/src/main/kotlin/com/revenuecat/purchases/common/SharedPreferencesManager.kt
Outdated
Show resolved
Hide resolved
purchases/src/main/kotlin/com/revenuecat/purchases/common/SharedPreferencesManager.kt
Outdated
Show resolved
Hide resolved
| editor.putFloat(key, value) | ||
| true | ||
| } | ||
| is Set<*> -> { |
purchases/src/test/java/com/revenuecat/purchases/common/SharedPreferencesManagerTest.kt
Outdated
Show resolved
Hide resolved
JayShortway
approved these changes
Aug 22, 2025
purchases/src/main/kotlin/com/revenuecat/purchases/common/SharedPreferencesManager.kt
Outdated
Show resolved
Hide resolved
purchases/src/main/kotlin/com/revenuecat/purchases/common/SharedPreferencesManager.kt
Outdated
Show resolved
Hide resolved
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 25, 2025
### Description We migrated to a new shared preferences file in #2621, but we didn't update the integration tests to use the new file. This fixes those integration tests.
tonidero
added a commit
that referenced
this pull request
Aug 25, 2025
### Description We were storing data in the default shared preferences file, which could potentially be used by the app developer. That's a bad practice and it's more difficult to do some things with. This PR changes to a separate shared preferences file and adds a migration, so we migrate all RC data from the previous shared preferences file to the new one. We won't delete the data from the previous shared preferences file, but that will remain unused.
tonidero
added a commit
that referenced
this pull request
Aug 25, 2025
### Description We migrated to a new shared preferences file in #2621, but we didn't update the integration tests to use the new file. This fixes those integration tests.
tonidero
pushed a commit
that referenced
this pull request
Aug 25, 2025
**This is an automatic release.** ## RevenueCat SDK ### 🐞 Bugfixes * Fix embedded font family loading (#2624) via Toni Rico (@tonidero) ### 🔄 Other Changes * Fix integration tests shared preferences file (#2629) via Toni Rico (@tonidero) * Migrate RC SharedPreferences data to a separate file (#2621) via Toni Rico (@tonidero) * Add annotation experimental library to debug builds (#2617) via Toni Rico (@tonidero) Co-authored-by: revenuecat-ops <ops@revenuecat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We were storing data in the default shared preferences file, which could potentially be used by the app developer. That's a bad practice and it's more difficult to do some things with. This PR changes to a separate shared preferences file and adds a migration, so we migrate all RC data from the previous shared preferences file to the new one. We won't delete the data from the previous shared preferences file, but that will remain unused.