Migrate amazon & debugview modules to KTS #2327
Conversation
library.gradle
Outdated
| @@ -25,12 +25,6 @@ android { | |||
| } | |||
| } | |||
|
|
|||
| project.afterEvaluate { | |||
| // Remove afterEvaluate | |||
| // after https://github.com/Kotlin/kotlinx-kover/issues/362 is fixed | |||
There was a problem hiding this comment.
Kover is now failing. Maybe this was needed after all?
### Motivation As we've discussed, making purchases module to transitive dependency for the `ui` module. I'm going to apply for the `amazon` module as well once #2327 is merged.
|
@tonidero @JayShortway Do you have any ideas for passing the test workflow? 😄 |
…tomEntitlementComputation" flavor.
|
Ugh, those Amazon tests are now failing with
I don't know what causes it, but I've seen it reported before: RevenueCat/purchases-kmp#271 I think it's related to the Amazon dependency and JDK version, but I don't know why it's suddenly an issue. Maybe updating the dependency from 3.0.5 to 3.0.7 helps? (Although there's nothing mentioned in the changelog.) Otherwise we can try setting |
|
@JayShortway This (296e40e) fixed on my local device but it stills failed on CI 😞 |
|
@skydoves Hmm I don't think it's Amazon anymore. The failures are different this time.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2327 +/- ##
=======================================
Coverage 78.32% 78.32%
=======================================
Files 300 300
Lines 11126 11126
Branches 1551 1551
=======================================
Hits 8714 8714
Misses 1732 1732
Partials 680 680 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@JayShortway @tonidero Eventually it has passed! 🚀 Thank you so much for your support and patience! |
|
@skydoves Awesome, thanks for persisting! 😄 Glad to get this in. |
**This is an automatic release.** ## RevenueCat SDK ### 🐞 Bugfixes * Use `Block store` to backup anonymous user ids across installations (#2595) via Toni Rico (@tonidero) ## RevenueCatUI SDK ### Paywallv2 #### 🐞 Bugfixes * Fixes price formatting discrepancies on Paywalls for `{{ product.price_per_[day|week|month|year] }}` (#2604) via JayShortway (@JayShortway) ### 🔄 Other Changes * Revert dokka 2 and gradle 9 update (#2618) via Toni Rico (@tonidero) * Introduce runtime annotations library and add stability annotations for increasing UI performances (#2608) via Jaewoong Eum (@skydoves) * Override presented offering context paywalls without offering (#2612) via Toni Rico (@tonidero) * Add APIs for hybrid SDKs to set presentedOfferingContext (#2610) via Toni Rico (@tonidero) * Bump Baseline Profiles to 1.4.0 and update profiles (#2611) via Jaewoong Eum (@skydoves) * Migrate deprecated kotlinOptions to compilerOptions (#2607) via Jaewoong Eum (@skydoves) * [AUTOMATIC][Paywalls V2] Updates paywall-preview-resources submodule (#2613) via RevenueCat Git Bot (@RCGitBot) * Migrate amazon & debugview modules to KTS (#2327) via Jaewoong Eum (@skydoves) * Update to Dokka 2.0.0 (#2609) via Toni Rico (@tonidero) * Add log when restoring purchases finds no purchases with some troubleshooting (#2599) via Toni Rico (@tonidero) Co-authored-by: revenuecat-ops <ops@revenuecat.com>
- Migrate `amazon` & `debugview` modules to KTS - Bump kover to 0.7.2 and remove the `afterEvaluate` tasks. (refer to Kotlin/kotlinx-kover#362) --------- Co-authored-by: JayShortway <29483617+JayShortway@users.noreply.github.com>
Motivation
amazon&debugviewmodules to KTSafterEvaluatetasks. (refer to applicationVariants/libraryVariants are eagerly evaluated and result in missed test data Kotlin/kotlinx-kover#362)