Fix default rocm path #283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running into `fatal error: hip/hip_runtime.h: No such file or directory` with latest wheel due to incorrect directory for ROCm libs
|
Merging CI green at least |
pytorchmergebot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Aug 6, 2023
This is required for a fix in latest nightly wheels in which the hip_runtime header file cannot be found during triton lowering ``` /tmp/tmpqoq6gtl8/main.c:3:14: fatal error: hip/hip_runtime.h: No such file or directory 3 | #include <hip/hip_runtime.h> | ^~~~~~~~~~~~~~~~~~~ ``` This is a single commit update to bring in this change ROCm/triton#283 Pull Request resolved: #106616 Approved by: https://github.com/malfet
Cyril-Anto
pushed a commit
to Cyril-Anto/pytorch
that referenced
this pull request
Aug 17, 2023
This is required for a fix in latest nightly wheels in which the hip_runtime header file cannot be found during triton lowering ``` /tmp/tmpqoq6gtl8/main.c:3:14: fatal error: hip/hip_runtime.h: No such file or directory 3 | #include <hip/hip_runtime.h> | ^~~~~~~~~~~~~~~~~~~ ``` This is a single commit update to bring in this change ROCm/triton#283 Pull Request resolved: pytorch#106616 Approved by: https://github.com/malfet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running into
fatal error: hip/hip_runtime.h: No such file or directorywith latest wheel due to incorrect directory for ROCm libsPreviously default path was:
/opt/_internal/cpython-3.8.17/lib/python3.8/site-packages/triton/common/third_party/rocmNow
/opt/_internal/cpython-3.8.17/lib/python3.8/site-packages/triton/common/../third_party/rocm