Skip to content

dist/tools/compile_test: specify toolchain and exit code #21534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 4, 2025
Merged

dist/tools/compile_test: specify toolchain and exit code #21534

merged 2 commits into from
Jun 4, 2025

Conversation

mguetschow
Copy link
Contributor

Contribution description

This PR changes dist/tools/compile_test/compile_like_murdock.py to

  1. allow specifying the used toolchain (hardcoded to gnu (backwards-compatible default) and llvm)
  2. return an error code on exit if any of the builds failed (this is a breaking change as it was before always returning success)

Testing procedure

Let's hope no other tool was relying on the exit code being always zero, hopefully CI would catch that.

You can test the script locally with

dist/tools/compile_test/compile_like_murdock.py -a tests/pkg/fff tests/sys/shell -b native32 -t gnu
dist/tools/compile_test/compile_like_murdock.py -a tests/pkg/fff tests/sys/shell -b native32 -t llvm

The first should succeed, the latter fail.

Issues/PRs references

This is needed for RIOT-OS/riotdocker#256 and transitively to unblock the failing CI tests. Will need to be backported to the last release.

@github-actions github-actions bot added the Area: tools Area: Supplementary tools label Jun 4, 2025
@mguetschow mguetschow mentioned this pull request Jun 4, 2025
Merged
@mguetschow mguetschow added Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs labels Jun 4, 2025
@mguetschow mguetschow force-pushed the compile-test-like-former-buildtest branch from cb2b5f7 to 1227a0c Compare June 4, 2025 09:36
@mguetschow
Copy link
Contributor Author

Obviously blocked by #21532 as well.

@crasbe crasbe added the Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation label Jun 4, 2025
@riot-ci
Copy link

riot-ci commented Jun 4, 2025 •
edited
Loading

Murdock results

✔️ PASSED

3a3f115 dist/tools/compile_test: error exit code on any failed build

Success Failures Total Runtime
1 0 1 01m:25s

Artifacts

@mguetschow mguetschow force-pushed the compile-test-like-former-buildtest branch from 1227a0c to 3a3f115 Compare June 4, 2025 17:17
@mguetschow mguetschow enabled auto-merge June 4, 2025 17:17
@mguetschow mguetschow added this pull request to the merge queue Jun 4, 2025
Merged via the queue into RIOT-OS:master with commit 5c6c0c4 Jun 4, 2025
25 checks passed
@mguetschow mguetschow deleted the compile-test-like-former-buildtest branch June 5, 2025 07:29
@mguetschow mguetschow mentioned this pull request Jun 5, 2025
Merged
@mguetschow
Copy link
Contributor Author

Backport provided in #21540

@Teufelchen1 Teufelchen1 added this to the Release 2025.07 milestone Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crasbe crasbe crasbe approved these changes

@maribu maribu maribu approved these changes

Assignees
No one assigned
Labels
Area: tools Area: Supplementary tools CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
Release 2025.07
Development

Successfully merging this pull request may close these issues.
5 participants
@mguetschow @riot-ci @crasbe @maribu @Teufelchen1