ci: tune down static test to a warning #21532
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not too familiar with the GitHub mechanisms, but generally this does appear to be sound. I don't think this needs a lot of testing before merging: there's still the maintainer looking over the PR before merge gets pressed, so let's do that, play around a bit on master, and if it doesn't perform as intended, we can still revert it. |
Murdock will run the static tests again after a rebase and will fail hard. There have been a few instances where static tests failed due to e.g. a newer version of codespell finding more typos, or a newer docker image needing to be tagged. Even PRs completely unrated to this needed to be rebased on `master` to unblock the merge. If we tune down the error to a warning, maintainers would be enabled to just merge anyway without the rebase, relying on the merge commit to still work. An accidental merge of failing static test would still be prevented by Murdock.
fc1c017 to
8fb43ff
Compare
mguetschow
approved these changes
Jun 4, 2025
There was a problem hiding this comment.
As @chrysn said, looks sound. Let's try if an approval actually unblocks the static test CI execution.
|
This had to be done with the Github UI. So this PR is not needed anymore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
Murdock will run the static tests again after a rebase and will fail hard.
There have been a few instances where static tests failed due to e.g. a newer version of codespell finding more typos, or a newer docker image needing to be tagged. Even PRs completely unrated to this needed to be rebased on
masterto unblock the merge. If we tune down the error to a warning, maintainers would be enabled to just merge anyway without the rebase, relying on the merge commit to still work. An accidental merge of failing static test would still be prevented by Murdock.Testing procedure
If the new action is already executed, this should hopefully create a warning in the static tests instead of a failure.
Issues/PRs references
None