tests/unittests/tests-hashes: fix wrong string length #20165
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
Incorrect use of
sizeof
for string length in testtest_hashes_sha512_hash_update_twice
.static const char *teststring
is a pointer, thereforesizeof(teststring)
returns the pointer size instead of the intended string length.This PR usesstrlen
instead ofsizeof
to fix this. Alternatively, we could change the type of the string tostatic const char teststring[]
.Note the subtle difference betweensizeof(char[])
andstrlen
: The former includes the null terminator, whilestrlen
does not. This should not change the test behavior.Edit:
This PR changes the type to
static const char teststring[]
so thatsizeof
returns the string length (including the null terminator).Testing procedure
Compile and run unittests.
Note for 32-bit architectures: The test also passed before, but only used 4 and 3+1 bytes of the string.