Skip to content

boards/nucleo-f767zi: Fix13179 make nucleo-f767zi debuggable again [backport 2020.01] #13531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 5, 2020
Merged

boards/nucleo-f767zi: Fix13179 make nucleo-f767zi debuggable again [backport 2020.01] #13531

merged 2 commits into from
Mar 5, 2020

Conversation

kfessel
Copy link
Contributor

@kfessel kfessel commented Mar 2, 2020

Backport of #13470

Reverts #13179 which introduced debugging issues due to misinformation of openocd and thereby gdb

Contribution description

Fixes the issue that #13179 tried to address by making the flash probing work on the nucleo-f767zi.
Might generaly improve probing Results due to switching from system reset to system halt after reset.

Testing procedure

The issue #13179 tried fixed:

make -C tests/riotboot/ BOARD=nucleo-f767zi flash

would fail due to openocd not being able to probe flash while srst is asserted

the issue #13179 generated

 make  -C tests/riotboot/ BOARD=nucleo-f767zi debug

lead to gdb telling me:

warning: Overlapping regions in memory map: ignoring

Issues/PRs references

Fixes #13179 this is the same as #13457 but with the patch for openocd.sh added

This was referenced Mar 2, 2020
Merged
Closed
@fjmolinas fjmolinas added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: release backport Integration Process: The PR is a release backport of a change previously provided to master Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) labels Mar 3, 2020
@fjmolinas
Copy link
Contributor

I'll provide the toolchain update backport to fix the build issue.

@kfessel kfessel mentioned this pull request Mar 3, 2020
Merged
@kfessel
Copy link
Contributor Author

kfessel commented Mar 3, 2020

ACK, the build errors seem unrelated

@fjmolinas
Copy link
Contributor

@kfessel Yes, but backports have the requirement that it must be rebased on the branch to be merged :/, sorry for all the trouble, do you mind rebasing? That should be the only thing missing

@kfessel kfessel force-pushed the backport/2020.01/fix13179 branch from b30cc41 to f550fe0 Compare March 4, 2020 10:44
@kfessel
Copy link
Contributor Author

kfessel commented Mar 4, 2020

done

fjmolinas
fjmolinas approved these changes Mar 5, 2020
View reviewed changes
Copy link
Contributor

@fjmolinas fjmolinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK!

@fjmolinas
Copy link
Contributor

GO! Thanks for getting the proper fix done @kfessel, sorry for all the extra work you had to deal with it!

@fjmolinas fjmolinas merged commit 43a90e2 into RIOT-OS:2020.01-branch Mar 5, 2020
@kfessel kfessel deleted the backport/2020.01/fix13179 branch March 5, 2020 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjmolinas fjmolinas fjmolinas approved these changes

Assignees
No one assigned
Labels
CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: release backport Integration Process: The PR is a release backport of a change previously provided to master Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kfessel @fjmolinas