Skip to content

credman: change credman_buffer_t::s type to 'const void *' #12299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 24, 2019
Merged

credman: change credman_buffer_t::s type to 'const void *' #12299

merged 1 commit into from
Sep 24, 2019

Conversation

pokgak
Copy link
Contributor

@pokgak pokgak commented Sep 24, 2019

Contribution description

This is a fix to the problem described in comment.

Testing procedure

Building #11943 without this change will produce error:

error: initialization discards 'const' qualifier from pointer target type [-Werror=discarded-qualifiers]

With this change, the error is gone.

pokgak pushed a commit to pokgak/RIOT that referenced this pull request Sep 24, 2019
fixup! update to credman fix RIOT-OS#12299
653e89a
@pokgak pokgak mentioned this pull request Sep 24, 2019
Merged
@miri64 miri64 self-requested a review September 24, 2019 18:00
@miri64 miri64 added Area: security Area: Security-related libraries and subsystems CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: API change Integration Process: PR contains or issue proposes an API change. Should be handled with care. Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) labels Sep 24, 2019
miri64
miri64 approved these changes Sep 24, 2019
View reviewed changes
Copy link
Member

@miri64 miri64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The pointer is not supposed to have the value changed and everything should still compile. Let's wait and see Murdock's verdict.

@miri64
Copy link
Member

miri64 commented Sep 24, 2019

and go

@miri64 miri64 merged commit cecdd57 into RIOT-OS:master Sep 24, 2019
pokgak pushed a commit to pokgak/RIOT that referenced this pull request Sep 24, 2019
fixup! update to credman fix RIOT-OS#12299
894ffe5
@kb2ma kb2ma added this to the Release 2019.10 milestone Sep 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miri64 miri64 miri64 approved these changes

Assignees
No one assigned
Labels
Area: security Area: Security-related libraries and subsystems CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: API change Integration Process: PR contains or issue proposes an API change. Should be handled with care. Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
Release 2019.10
Development

Successfully merging this pull request may close these issues.
3 participants
@pokgak @miri64 @kb2ma