Skip to content

drivers/shtcx: fix assertion and shtcx_saul_info idx #19690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 1, 2023
Merged

drivers/shtcx: fix assertion and shtcx_saul_info idx #19690

merged 1 commit into from
Jun 1, 2023

Conversation

benpicco
Copy link
Contributor

Contribution description

Testing procedure

In master the assertion triggers:

2023-05-31 14:30:08,173 - INFO # 4e7f
2023-05-31 14:30:08,173 - INFO # 
2023-05-31 14:30:08,173 - INFO # Context before hardfault:
2023-05-31 14:30:08,174 - INFO #    r0: 0x00000005
2023-05-31 14:30:08,174 - INFO #    r1: 0x2000544d
2023-05-31 14:30:08,175 - INFO #    r2: 0x00000005
2023-05-31 14:30:08,175 - INFO #    r3: 0x12000000
2023-05-31 14:30:08,175 - INFO #   r12: 0x00000005
2023-05-31 14:30:08,189 - INFO #    lr: 0x0000056b
2023-05-31 14:30:08,189 - INFO #    pc: 0x0000056a
2023-05-31 14:30:08,190 - INFO #   psr: 0x21000000
2023-05-31 14:30:08,190 - INFO # 
2023-05-31 14:30:08,190 - INFO # FSR/FAR:
2023-05-31 14:30:08,191 - INFO #  CFSR: 0x00000000
2023-05-31 14:30:08,191 - INFO #  HFSR: 0x80000000
2023-05-31 14:30:08,192 - INFO #  DFSR: 0x00000002
2023-05-31 14:30:08,192 - INFO #  AFSR: 0x00000000
2023-05-31 14:30:08,193 - INFO # Misc
2023-05-31 14:30:08,193 - INFO # EXC_RET: 0xfffffffd
2023-05-31 14:30:08,194 - INFO # Active thread: 1 "main"
2023-05-31 14:30:08,205 - INFO # Attempting to reconstruct state for debugging...
2023-05-31 14:30:08,206 - INFO # In GDB:
2023-05-31 14:30:08,206 - INFO #   set $pc=0x56a
2023-05-31 14:30:08,207 - INFO #   frame 0
2023-05-31 14:30:08,207 - INFO #   bt

With this patch, SAUL works as expected

2023-05-31 14:47:05,778 - INFO # > saul
2023-05-31 14:47:05,778 - INFO # 
2023-05-31 14:47:05,779 - INFO # ID	Class		Name
2023-05-31 14:47:05,780 - INFO # #0	ACT_SWITCH	LED_YEL_ETH
2023-05-31 14:47:05,780 - INFO # #1	ACT_SWITCH	LED0
2023-05-31 14:47:05,781 - INFO # #2	SENSE_TEMP	shtcx temperature
2023-05-31 14:47:05,782 - INFO # #3	SENSE_HUM	shtcx humidity

2023-05-31 14:47:11,330 - INFO # > saul read 2
2023-05-31 14:47:11,330 - INFO # 
2023-05-31 14:47:11,346 - INFO # Reading from #2 (shtcx temperature|SENSE_TEMP)
2023-05-31 14:47:11,347 - INFO # Data:	          29.80 °C

2023-05-31 14:47:13,826 - INFO # > saul read 3
2023-05-31 14:47:13,826 - INFO # 
2023-05-31 14:47:13,842 - INFO # Reading from #3 (shtcx humidity|SENSE_HUM)
2023-05-31 14:47:13,842 - INFO # Data:	          20.35 %

Issues/PRs references

@github-actions github-actions bot added Area: drivers Area: Device drivers Area: SAUL Area: Sensor/Actuator Uber Layer labels May 31, 2023
@benpicco benpicco added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels May 31, 2023
@benpicco benpicco requested a review from maribu May 31, 2023 13:01
@riot-ci
Copy link

riot-ci commented May 31, 2023

Murdock results

✔️ PASSED

7457c45 drivers/shtcx: fix assertion and shtcx_saul_info idx

Success Failures Total Runtime
6933 0 6933 12m:34s

Artifacts

@maribu
Copy link
Member

maribu commented May 31, 2023

bors merge

bors bot added a commit that referenced this pull request May 31, 2023
@bors @benpicco
Merge #19689 #19690
8322e3d 
19689: cpu/sam0_eth: disable PHY when MAC is sleeping r=aabadie a=benpicco





19690: drivers/shtcx: fix assertion and shtcx_saul_info idx r=maribu a=benpicco



Co-authored-by: Benjamin Valentin <benjamin.valentin@ml-pa.com>
@bors
Copy link
Contributor

bors bot commented May 31, 2023

Build failed (retrying...):

@bors
Copy link
Contributor

bors bot commented Jun 1, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 2eb45f9 into RIOT-OS:master Jun 1, 2023
@benpicco benpicco deleted the auto_init_shtcx-fix branch June 1, 2023 11:54
@benpicco benpicco added this to the Release 2023.07 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maribu maribu maribu approved these changes

Assignees
No one assigned
Labels
Area: drivers Area: Device drivers Area: SAUL Area: Sensor/Actuator Uber Layer CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
Release 2023.07
Development

Successfully merging this pull request may close these issues.
3 participants
@benpicco @riot-ci @maribu