Skip to content

gnrc_sixlowpan_iphc: fix NULL pointer dereference #19678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2023

Conversation

miri64
Copy link
Member

@miri64 miri64 commented May 30, 2023

Contribution description

See GHSA-r2pv-3jqc-vh7w.

Testing procedure

Issues/PRs references

@github-actions github-actions bot added Area: network Area: Networking Area: sys Area: System labels May 30, 2023
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label May 30, 2023
Copy link
Contributor

@benpicco benpicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@miri64 miri64 added the Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) label May 30, 2023
@riot-ci
Copy link

riot-ci commented May 30, 2023

Murdock results

✔️ PASSED

c9d7863 gnrc_sixlowpan_iphc: fix NULL pointer dereference

Success Failures Total Runtime
6933 0 6933 13m:05s

Artifacts

@maribu
Copy link
Member

maribu commented May 30, 2023

bors merge

bors bot added a commit that referenced this pull request May 30, 2023
19678: gnrc_sixlowpan_iphc: fix NULL pointer dereference r=maribu a=miri64



Co-authored-by: Martine Lenders <m.lenders@fu-berlin.de>
@maribu
Copy link
Member

maribu commented May 30, 2023

bors cancel
bors merge

@bors
Copy link
Contributor

bors bot commented May 30, 2023

Canceled.

bors bot added a commit that referenced this pull request May 30, 2023
19677: boards/nucleo-l432k: provide three periph_timer instances r=maribu a=maribu

### Contribution description

- `cpu/stm32/periph_timer`: Generalize to also work with timers that do not have 4 channels
- `boards/common/stm32`: Add timer config for three timers based on TIM2, TIM15, and TIM16 (the three general-purpose timers of the STM32L4)
- `boards/nucleo-l432kc`: Make use of the new timer config


19678: gnrc_sixlowpan_iphc: fix NULL pointer dereference r=maribu a=miri64



19681: sys/xtimer: improve documentation r=maribu a=maribu

### Contribution description

- Add a warning that xtimer is deprecated, so that new code hopefully starts using ztimer
- Add a hint that `ztimer_xtimer_compat` can be used even after `xtimer` is gone


Co-authored-by: Marian Buschsieweke <marian.buschsieweke@ovgu.de>
Co-authored-by: Martine Lenders <m.lenders@fu-berlin.de>
@bors
Copy link
Contributor

bors bot commented May 30, 2023

Build failed (retrying...):

@miri64
Copy link
Member Author

miri64 commented May 30, 2023

tests/drivers/servo failed... Looks unrelated Oo

@maribu
Copy link
Member

maribu commented May 30, 2023

It was a timeout during a long rust build, likely caused because cargo fetches are slow now. The exact same thing happened on a different worker before. I think it is caused by upstream repos being a bit slower now then they used to be. But I'd actually blame our lack of caching of remote resources in our CI.

@miri64
Copy link
Member Author

miri64 commented May 30, 2023

Github was very slow the past few days, but only from some ISPs. Maybe it's related.

bors bot added a commit that referenced this pull request May 30, 2023
19610: drivers/periph/rtc: improve doc on rtc_set_alarm r=maribu a=maribu

### Contribution description

- point out behavior on denormalized time stamps
- use errno codes to indicate errors (and adapt the few instances of actual error handling to use them)


19670: cpu/stm32: stm32f4 BRR from BSRR r=maribu a=kfessel

### Contribution description

sometimes one wants to save one instruction :) 
just write the bits we need to write.

### Testing procedure

tests/periph/gpio_ll tests this 

### Issues/PRs references

`@maribu` might know some reference

maybe #19407

19678: gnrc_sixlowpan_iphc: fix NULL pointer dereference r=maribu a=miri64



19679: gnrc_sixlowpan_frag_sfr: fix ARQ scheduler race-condition r=maribu a=miri64



19680: gnrc_sixlowpan_frag_rb: fix OOB write in _rbuf_add r=maribu a=miri64



19681: sys/xtimer: improve documentation r=maribu a=maribu

### Contribution description

- Add a warning that xtimer is deprecated, so that new code hopefully starts using ztimer
- Add a hint that `ztimer_xtimer_compat` can be used even after `xtimer` is gone


Co-authored-by: Marian Buschsieweke <marian.buschsieweke@ovgu.de>
Co-authored-by: Karl Fessel <karl.fessel@ovgu.de>
Co-authored-by: Martine Lenders <m.lenders@fu-berlin.de>
@bors
Copy link
Contributor

bors bot commented May 30, 2023

This PR was included in a batch that was canceled, it will be automatically retried

@bors bors bot merged commit 00b5bc1 into RIOT-OS:master May 30, 2023
@bors
Copy link
Contributor

bors bot commented May 30, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@miri64 miri64 deleted the gnrc_sixlowpan_iphc/bug/null-ptr-ref branch May 30, 2023 20:29
@benpicco benpicco added this to the Release 2023.07 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: network Area: Networking Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants