Skip to content

treewide: fix typos and false positives found by codespell #19528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 2, 2023

Conversation

maribu
Copy link
Member

@maribu maribu commented May 1, 2023

Contribution description

This fixes some typos and adds one correctly used abbreviation to the ignore list.

Testing procedure

If bors merges this without static tests failing, it did what it intended to do.

Issues/PRs references

Fixes issues that prevent #19440 from merging

@maribu maribu added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label May 1, 2023
@maribu maribu requested a review from dylad May 1, 2023 19:20
@maribu maribu requested a review from basilfx as a code owner May 1, 2023 19:20
@github-actions github-actions bot added Area: boards Area: Board ports Area: doc Area: Documentation Area: tools Area: Supplementary tools labels May 1, 2023
@riot-ci
Copy link

riot-ci commented May 1, 2023

Murdock results

✔️ PASSED

73e7e30 dist/tools/codespell: ignore false positives

Success Failures Total Runtime
6931 0 6931 09m:46s

Artifacts

@github-actions github-actions bot added Area: cpu Area: CPU/MCU ports Platform: native Platform: This PR/issue effects the native platform labels May 1, 2023
@github-actions github-actions bot added Area: drivers Area: Device drivers Area: network Area: Networking Area: pkg Area: External package ports Area: sys Area: System Area: tests Area: tests and testing framework Area: timers Area: timer subsystems Platform: ARM Platform: This PR/issue effects ARM-based platforms labels May 1, 2023
@maribu
Copy link
Member Author

maribu commented May 1, 2023

Maybe it makes sense to squash this into three commits:

  1. treewide: fix typos in comments
  2. sys/ztimer: fix typo in debug output
  3. dist/tools/codespell: ignore false positives

@@ -17,6 +17,9 @@ dout
# ALS (Ambient Light Sensing) => ALSO
als

# CAF (Comp. A Enable Output Filter (MSP430) or Copy All Frames (SAM0) or C++ Actor Framework) => CALF
CAF
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
CAF
caf

Uppercase doesn't work?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, now static tests are passing

maribu added 3 commits May 2, 2023 09:52
This will not change generated binaries, only the Doxygen output and
source code will have less typos.
Add two false positives to the list of words to ignore.
@maribu maribu force-pushed the dist/tools/codespell branch from 0c91d3d to 73e7e30 Compare May 2, 2023 07:54
Copy link
Contributor

@aabadie aabadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@aabadie
Copy link
Contributor

aabadie commented May 2, 2023

bors merge

@bors
Copy link
Contributor

bors bot commented May 2, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit a91449d into RIOT-OS:master May 2, 2023
bors bot added a commit that referenced this pull request May 10, 2023
19561: cpu/esp32: fix compilation issues with GCC 12.2 [backport 2023.04] r=maribu a=kaspar030

# Backport of #19450

### Contribution description

This PR provides the changes in `cpu/esp32` and `cpu/esp_common` to fix the compilation issues with GCC v12.2.  It is required as the first step in the preparation of the upgrade to ESP-IDF version 5.1.

**Please note**: Insead of fixing the ESP-IDF 4.4 code itself by a big bunch of patches to fix the compilation problems with GCC v12.2, it temporarily disables some warnings. The reason is that the ESP-IDF 5.1 requires GCC v12.2 and should be fixed for this compiler version by the vendor.

### Testing procedure

Green CI

The change were already tested with all ESP-specific modules like `esp_now`, `esp_wifi`, `esp_spi`  and `esp_ble` for all supported ESP platforms.

### Issues/PRs references

Prerequisite for RIOT-OS/riotdocker#227
Fixes issue #19421

19563: treewide: fix typos and false positives found by codespell [backport 2023.04] r=maribu a=MrKevinWeiss

# Backport of #19528

### Contribution description

This fixes some typos and adds one correctly used abbreviation to the ignore list.



Co-authored-by: Gunar Schorcht <gunar@schorcht.net>
Co-authored-by: Marian Buschsieweke <marian.buschsieweke@ovgu.de>
@maribu maribu deleted the dist/tools/codespell branch July 3, 2023 13:22
@benpicco benpicco added this to the Release 2023.07 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: boards Area: Board ports Area: cpu Area: CPU/MCU ports Area: doc Area: Documentation Area: drivers Area: Device drivers Area: network Area: Networking Area: pkg Area: External package ports Area: sys Area: System Area: tests Area: tests and testing framework Area: timers Area: timer subsystems Area: tools Area: Supplementary tools CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms Platform: native Platform: This PR/issue effects the native platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants