Skip to content

boards/arduino-mkrwan1300: update board name to correct one #19526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2023

Conversation

FlapKap
Copy link
Contributor

@FlapKap FlapKap commented May 1, 2023

Contribution description

The board name in the documentation for the Arduino MKR WAN 1300 is wrong (https://doc.riot-os.org/group__boards__arduino-mkrwan1300.html). I presume since it was part of a larger pull-request and simply got overlooked.

Testing procedure

Read the doc.txt and check that it matches the name of the board folder.

Issues/PRs references

@github-actions github-actions bot added Area: boards Area: Board ports Area: doc Area: Documentation labels May 1, 2023
Copy link
Contributor

@aabadie aabadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this!

ACK

@aabadie aabadie added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label May 2, 2023
@riot-ci
Copy link

riot-ci commented May 2, 2023

Murdock results

✔️ PASSED

ac315a6 boards/arduino-mkrwan1300: update board name to correct one

Success Failures Total Runtime
1 0 1 55s

Artifacts

@aabadie
Copy link
Contributor

aabadie commented May 2, 2023

bors merge

bors bot added a commit that referenced this pull request May 2, 2023
19526: boards/arduino-mkrwan1300: update board name to correct one r=aabadie a=FlapKap



Co-authored-by: Kasper Hjort Berthelsen <kasper.berthelsen@hotmail.com>
@bors
Copy link
Contributor

bors bot commented May 2, 2023

Build failed:

  • static-tests

@aabadie
Copy link
Contributor

aabadie commented May 2, 2023

bors merge

@bors
Copy link
Contributor

bors bot commented May 2, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 8573fab into RIOT-OS:master May 2, 2023
@FlapKap FlapKap deleted the fix/arduino-mkrwan1300-naming branch May 2, 2023 11:05
@benpicco benpicco added this to the Release 2023.07 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: boards Area: Board ports Area: doc Area: Documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants