Skip to content

drivers/usbdev_synopsys_dwc2: add ESP32x power management #19399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 16, 2023
Merged

drivers/usbdev_synopsys_dwc2: add ESP32x power management #19399

merged 1 commit into from
Mar 16, 2023

Conversation

gschorcht
Copy link
Contributor

Contribution description

This PR adds power management handling for ESP32x SoCs.

Testing procedure

Use and ESP32-S2 or ESP32-S3 board and flash tests/periph_pm using the stdio_cdc_acm

USEMODULE=stdio_cdc_acm BOARD=esp32s3-devkit make -j8 -C tests/periph_pm flash

Connect the terminal to the board and execute command:

set_rtc 1 1

The console should continue to work after the 1-s light sleep.

Issues/PRs references

@github-actions github-actions bot added the Area: drivers Area: Device drivers label Mar 16, 2023
@gschorcht gschorcht force-pushed the drivers/usbdev_synopsys_dwc2/enable_esp32_pm branch from fe5d34c to d388055 Compare March 16, 2023 11:28
@gschorcht gschorcht added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Mar 16, 2023
@riot-ci
Copy link

riot-ci commented Mar 16, 2023

Murdock results

✔️ PASSED

d388055 drivers/usbdev_synopsys_dwc2: add ESP32x power management

Success Failures Total Runtime
6882 0 6882 09m:21s

Artifacts

@benpicco benpicco requested a review from jue89 March 16, 2023 11:55
benpicco
benpicco approved these changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@benpicco benpicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

bors bot added a commit that referenced this pull request Mar 16, 2023
@bors @gschorcht
Merge #19399
7aab85f 
19399: drivers/usbdev_synopsys_dwc2: add ESP32x power management r=benpicco a=gschorcht

### Contribution description

This PR adds power management handling for ESP32x SoCs.

### Testing procedure

Use and ESP32-S2 or ESP32-S3 board and flash `tests/periph_pm` using the `stdio_cdc_acm`
```
USEMODULE=stdio_cdc_acm BOARD=esp32s3-devkit make -j8 -C tests/periph_pm flash
```
Connect the terminal to the board and execute command:
```
set_rtc 1 1
```
The console should continue to work after the 1-s light sleep.

### Issues/PRs references


Co-authored-by: Gunar Schorcht <gunar@schorcht.net>
@benpicco
Copy link
Contributor

bors cancel
bors merge

@bors
Copy link
Contributor

bors bot commented Mar 16, 2023

Canceled.

@bors
Copy link
Contributor

bors bot commented Mar 16, 2023

Build succeeded:

@bors bors bot merged commit 1a787d4 into RIOT-OS:master Mar 16, 2023
@gschorcht
Copy link
Contributor Author

Thanks

@gschorcht gschorcht deleted the drivers/usbdev_synopsys_dwc2/enable_esp32_pm branch April 12, 2023 14:10
@MrKevinWeiss MrKevinWeiss added this to the Release 2023.04 milestone Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benpicco benpicco benpicco approved these changes

@jue89 jue89 Awaiting requested review from jue89

Assignees
No one assigned
Labels
Area: drivers Area: Device drivers CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
Release 2023.04
Development

Successfully merging this pull request may close these issues.
4 participants
@gschorcht @riot-ci @benpicco @MrKevinWeiss