Skip to content

Conversation

benpicco
Copy link
Contributor

@benpicco benpicco commented Feb 27, 2023

Contribution description

The warning got fixed upstream, we can drop -Wno-error=sign-compare

Testing procedure

Issues/PRs references

olikraus/u8g2#2101

@benpicco benpicco requested a review from basilfx as a code owner February 27, 2023 15:01
@benpicco benpicco added Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Feb 27, 2023
@github-actions github-actions bot added the Area: pkg Area: External package ports label Feb 27, 2023
@benpicco benpicco requested review from gschorcht and maribu February 27, 2023 15:01
@riot-ci
Copy link

riot-ci commented Feb 27, 2023

Murdock results

✔️ PASSED

b054191 pkg/u8g2: bump version

Success Failures Total Runtime
6864 0 6864 10m:18s

Artifacts

@benpicco
Copy link
Contributor Author

bors merge

bors bot added a commit that referenced this pull request Feb 27, 2023
19321: examples/gnrc_border_router: add BLE as downlink option r=benpicco a=benpicco



19325: esptools/install.sh: Fix shellcheck issues r=benpicco a=bergzand

### Contribution description

Quote all the things!


### Testing procedure

The script should still work as before


### Issues/PRs references

None

19327: shell/cmds: GNRC: replace puts() with printf() r=benpicco a=benpicco



19328: pkg/u8g2: bump version r=benpicco a=benpicco



Co-authored-by: Benjamin Valentin <benjamin.valentin@ml-pa.com>
Co-authored-by: Koen Zandberg <koen@bergzand.net>
Co-authored-by: Benjamin Valentin <benpicco@beuth-hochschule.de>
@bors
Copy link
Contributor

bors bot commented Feb 27, 2023

Build failed (retrying...):

bors bot added a commit that referenced this pull request Feb 27, 2023
19327: shell/cmds: GNRC: replace puts() with printf() r=benpicco a=benpicco



19328: pkg/u8g2: bump version r=benpicco a=benpicco



Co-authored-by: Benjamin Valentin <benpicco@beuth-hochschule.de>
@bors
Copy link
Contributor

bors bot commented Feb 27, 2023

This PR was included in a batch that was canceled, it will be automatically retried

@benpicco
Copy link
Contributor Author

bors cancel
bors merge

@bors
Copy link
Contributor

bors bot commented Feb 27, 2023

Canceled.

@bors
Copy link
Contributor

bors bot commented Feb 27, 2023

Build succeeded:

@bors bors bot merged commit 6b501f7 into RIOT-OS:master Feb 27, 2023
@benpicco benpicco deleted the pkg/u8g2-bump2 branch February 27, 2023 20:02
@MrKevinWeiss MrKevinWeiss added this to the Release 2023.04 milestone Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants