Skip to content

Conversation

benpicco
Copy link
Contributor

@benpicco benpicco commented Feb 15, 2023

Contribution description

The name of the module is shell_cmd_gnrc_udp.

Testing procedure

Issues/PRs references

@benpicco benpicco requested review from maribu and miri64 February 15, 2023 12:36
@benpicco benpicco added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs labels Feb 15, 2023
@github-actions github-actions bot added the Area: build system Area: Build system label Feb 15, 2023
@benpicco benpicco added the Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer label Feb 15, 2023
@miri64 miri64 added the Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) label Feb 15, 2023
@riot-ci
Copy link

riot-ci commented Feb 15, 2023

Murdock results

✔️ PASSED

980b603 sys/shell/cmds: fix typo 'shell_cmd_grnc_udp'

Success Failures Total Runtime
1 0 1 52s

Artifacts

@miri64
Copy link
Member

miri64 commented Feb 15, 2023

bors merge

@bors
Copy link
Contributor

bors bot commented Feb 15, 2023

🕐 Waiting for PR status (GitHub check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set.

bors bot added a commit that referenced this pull request Feb 15, 2023
19280: sys/shell/cmds: fix typo 'shell_cmd_grnc_udp' r=miri64 a=benpicco



Co-authored-by: Benjamin Valentin <benpicco@beuth-hochschule.de>
@benpicco
Copy link
Contributor Author

bors cancel

bors merge

@bors
Copy link
Contributor

bors bot commented Feb 15, 2023

Canceled.

bors bot added a commit that referenced this pull request Feb 15, 2023
19270: drivers/at24cxxx: implement _mtd_at24cxxx_read_page r=benpicco a=HendrikVE

### Contribution description

The function `read_page` was missing which lead to (from a user perspective) undefined behavior on the MTD layer.

### Testing procedure

Any application using MTD in conjunction with a board with an at24cxxx.


19280: sys/shell/cmds: fix typo 'shell_cmd_grnc_udp' r=benpicco a=benpicco



Co-authored-by: Hendrik van Essen <hendrik.vanessen@ml-pa.com>
Co-authored-by: Benjamin Valentin <benpicco@beuth-hochschule.de>
@bors
Copy link
Contributor

bors bot commented Feb 15, 2023

Build failed (retrying...):

bors bot added a commit that referenced this pull request Feb 15, 2023
19280: sys/shell/cmds: fix typo 'shell_cmd_grnc_udp' r=benpicco a=benpicco



Co-authored-by: Benjamin Valentin <benpicco@beuth-hochschule.de>
@bors
Copy link
Contributor

bors bot commented Feb 15, 2023

Build failed:

@maribu
Copy link
Member

maribu commented Feb 15, 2023

bors merge

@bors
Copy link
Contributor

bors bot commented Feb 15, 2023

Build succeeded:

@bors bors bot merged commit 12910d6 into RIOT-OS:master Feb 15, 2023
@benpicco benpicco deleted the shell_cmd_grnc_udp branch February 15, 2023 16:49
@MrKevinWeiss MrKevinWeiss added this to the Release 2023.04 milestone Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: build system Area: Build system CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants