makefiles/suit: make it possible to accept multiple SUIT keys #18459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maribu
approved these changes
Jan 10, 2023
|
bors merge |
|
bors merge |
|
Already running a review |
bors bot
added a commit
that referenced
this pull request
Jan 13, 2023
18459: makefiles/suit: make it possible to accept multiple SUIT keys r=benpicco a=benpicco 18724: nanocoap_sock: implement DTLS socket r=benpicco a=benpicco 18763: sys/tiny_strerror: add missing error codes r=maribu a=maribu ### Contribution description When double-checking the error codes provided by newlib by default (without magic defines, such as `__LINUX_ERRNO_EXTENSIONS__` or `__CYGWIN__`), some where still missing in `tiny_strerror()`. This adds the missing ones. This in turn showed that three errno codes were missing in the avr-libc compat `errno.h`, which are added as well. ### Testing procedure Murdock should double check that the added errno codes indeed are defined by default. ### Issues/PRs references None Co-authored-by: Benjamin Valentin <benjamin.valentin@ml-pa.com> Co-authored-by: Benjamin Valentin <benjamin.valentin@bht-berlin.de> Co-authored-by: Marian Buschsieweke <marian.buschsieweke@ovgu.de>
|
re-shuffling merge train: bors cancel |
|
Canceled. |
bors bot
added a commit
that referenced
this pull request
Jan 13, 2023
18459: makefiles/suit: make it possible to accept multiple SUIT keys r=kaspar030 a=benpicco 18724: nanocoap_sock: implement DTLS socket r=benpicco a=benpicco 18763: sys/tiny_strerror: add missing error codes r=maribu a=maribu ### Contribution description When double-checking the error codes provided by newlib by default (without magic defines, such as `__LINUX_ERRNO_EXTENSIONS__` or `__CYGWIN__`), some where still missing in `tiny_strerror()`. This adds the missing ones. This in turn showed that three errno codes were missing in the avr-libc compat `errno.h`, which are added as well. ### Testing procedure Murdock should double check that the added errno codes indeed are defined by default. ### Issues/PRs references None 19136: CI: re-add "synchronize" event to check-labels r=kaspar030 a=kaspar030 Co-authored-by: Benjamin Valentin <benjamin.valentin@ml-pa.com> Co-authored-by: Benjamin Valentin <benjamin.valentin@bht-berlin.de> Co-authored-by: Marian Buschsieweke <marian.buschsieweke@ovgu.de> Co-authored-by: Kaspar Schleiser <kaspar@schleiser.de>
|
Build failed (retrying...): |
|
bors retry |
|
Already running a review |
|
bors cancel |
|
Canceled. |
|
bors merge |
|
Already running a review |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
A board may be flashed with a development firmware. The development firmware should accept SUIT updates signed with both the development and the production key.
Therefore allow to include multiple public keys to verify the SUIT manifest with.
Testing procedure
Run
tests/suit_manifestwith multiple keys, e.g.The tests should still success even though the 'wrong' key is tried first.
Issues/PRs references