Skip to content

Fix Clippy Lints for Rust 1.88 #1472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jul 1, 2025
Merged

Fix Clippy Lints for Rust 1.88 #1472

merged 10 commits into from
Jul 1, 2025

Conversation

IvanIsCoding
Copy link
Collaborator

Related to #1471

Right now, the lints are disabled. This PR actually fixes them. Most of the fixes were automated following commands along the lines of:

cargo clippy --fix --lib -p rustworkx

@IvanIsCoding IvanIsCoding requested a review from mtreinish June 29, 2025 02:18
@coveralls
Copy link

Pull Request Test Coverage Report for Build 15950552464

Details

  • 39 of 50 (78.0%) changed or added relevant lines in 16 files are covered.
  • 72 unchanged lines in 19 files lost coverage.
  • Overall coverage decreased (-0.6%) to 94.619%
Changes Missing Coverage Covered Lines Changed/Added Lines %
rustworkx-core/src/err.rs 0 1 0.0%
src/graph.rs 5 6 83.33%
src/graphml.rs 9 10 90.0%
src/json/mod.rs 1 2 50.0%
src/steiner_tree.rs 0 1 0.0%
src/json/node_link_data.rs 0 2 0.0%
rustworkx-core/src/dag_algo.rs 0 4 0.0%
Files with Coverage Reduction New Missed Lines %
rustworkx-core/src/centrality.rs 1 98.59%
rustworkx-core/src/generators/random_graph.rs 1 70.28%
rustworkx-core/src/steiner_tree.rs 1 96.55%
src/coloring.rs 1 98.82%
src/connectivity/johnson_simple_cycles.rs 1 97.44%
src/layout/spring.rs 1 99.56%
rustworkx-core/src/connectivity/biconnected.rs 2 97.62%
src/isomorphism/vf2.rs 2 96.01%
src/toposort.rs 2 89.38%
rustworkx-core/src/token_swapper.rs 3 95.59%
Totals Coverage Status
Change from base Build 15890388565: -0.6%
Covered Lines: 17760
Relevant Lines: 18770
💛 - Coveralls

mtreinish
mtreinish approved these changes Jul 1, 2025
View reviewed changes
Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this

@mtreinish mtreinish added this pull request to the merge queue Jul 1, 2025
Merged via the queue into Qiskit:main with commit d543e0d Jul 1, 2025
31 checks passed
SILIZ4 pushed a commit to SILIZ4/rustworkx that referenced this pull request Jul 4, 2025
@IvanIsCoding @SILIZ4
Fix Clippy Lints for Rust 1.88 (Qiskit#1472)
7517e65 
* Add ignore for files temporarily

* Address lint in test target as well

* Revert "Add ignore for files temporarily"

This reverts commit f8a8d03.

* Add first part of automated fixes

* Add second part of automated fixes

* Add third part of automated fixes

* Manual fix for missing line

* cargo fmt

* Undo the lint allows from merge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtreinish mtreinish mtreinish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IvanIsCoding @coveralls @mtreinish