Minor improvements: prevent future test failures, remove fixtures, and more
#1446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess I will need to be a little bit more clever on preventing NetworkX for failing (until 3.9 is dropped) |
|
Ok, Python 3.9 passes on CI now. |
Pull Request Test Coverage Report for Build 14954847005Details
💛 - Coveralls |
mtreinish
approved these changes
May 29, 2025
SILIZ4
pushed a commit
to SILIZ4/rustworkx
that referenced
this pull request
Jul 4, 2025
…and more (Qiskit#1446) * Fix typo (makes nox -elint happy) * Prevent tests from failing with Networkx 3.6 * Pin ruff * Use try/except to support Python 3.9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a collection of minor things:
fixturestest dependency. I don't know when we stopped using it but it seems it can gonox -elintfailruff. Right now, we haveruff~=0.6. Butruffhas not achieved a major version yet, so this is essentially running the latest version!