Adding fuzz target for contraction #1435
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a fuzz target for cycle check validation and idempotency check (calling contract_nodes twice doesn't crash)
Pull Request Test Coverage Report for Build 14759015542Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
|
I will start reviewing the PRs starting from this sometime around today/tomorrow |
|
Hey @IvanIsCoding, did you get time to review these? |
Not yet, I will try to review this and #1337 it’s what on the top of my list |
IvanIsCoding
approved these changes
Apr 30, 2025
|
|
||
| // Run contraction with cycle check (may fail) | ||
| let result = graph.contract_nodes(to_contract.clone(), input.replacement_weight, true); | ||
| if let Err(ContractError::DAGWouldCycle) = result { |
There was a problem hiding this comment.
Use a match call, with the Ok(_) branch covering the idempotency and the Err branch checking for ContractError::DAGWouldCycle
Something along the lines
match graph.contract_nodes(...) {
Ok(_) => { /* idempotency */},
Err(_) => {/* dag cycle */ }
}
IvanIsCoding
approved these changes
Apr 30, 2025
SILIZ4
pushed a commit
to SILIZ4/rustworkx
that referenced
this pull request
Jul 4, 2025
* Adding fuzz target for contraction Added a fuzz target for cycle check validation and idempotency check (calling contract_nodes twice doesn't crash) * Fixing Lint issues * Updates based on comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a fuzz target for cycle check validation and idempotency check (calling contract_nodes twice doesn't crash).