Add is_strongly_connected and number_strongly_connected_components methods #1400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 14021304022Details
💛 - Coveralls |
879d72f to
c04fe58
Compare
IvanIsCoding
approved these changes
Mar 22, 2025
There was a problem hiding this comment.
LGTM, just two minor items before merging:
- Add a release note for the new methods following CONTRIBUTING.md
- Fix the type stub return type
da1be5f to
9273d18
Compare
IvanIsCoding
approved these changes
Mar 23, 2025
SILIZ4
pushed a commit
to SILIZ4/rustworkx
that referenced
this pull request
Jul 4, 2025
…thods (Qiskit#1400) * Add is_strongly_connected method * Add number_strongly_connected_components method * Fix type annotation of output of two PyDiGraph methods * Add release note about is_strongly_connected and number_strongly_connected_components
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1399 I documented the connection methods and realized I could not find the
is_strongly_connectedandnumber_strong_connected_componentsmethods anywhere in the code.Since
is_weakly_connectedmethod looks like just checking the result ofweakly_connected_components, I tried my luck and cloned it foris_strongly_connectedfor code, docs, and tests. The same fornumber_strongly_connected_components.