-
Notifications
You must be signed in to change notification settings - Fork 191
Consolidate docstrings in digraph.rs #1396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pull Request Test Coverage Report for Build 13874803350Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! This is good to go. Some of those docstrings are at least 5 years old now, so it is good they are getting some attention now.
I left some comments on that I will apply myself, Python needs to be capitalized and we are clearly not doing it.
@@ -1275,15 +1281,15 @@ impl PyDiGraph { | |||
Ok(out_index) | |||
} | |||
|
|||
/// Add new edges to the dag. | |||
/// Add new edges to the graph. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice find! Originally PyDiGraph
was only for DAGs. PyDAG
took that role later
* Consolidate docstrings in digraph.rs * Apply suggestions from code review --------- Co-authored-by: Ivan Carvalho <8753214+IvanIsCoding@users.noreply.github.com>
Continuing the quest from #1395