Skip to content

Conversation

eumiro
Copy link
Contributor

@eumiro eumiro commented Mar 14, 2025

Continuing the quest from #1395

@coveralls
Copy link

coveralls commented Mar 14, 2025

Pull Request Test Coverage Report for Build 13874803350

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.313%

Totals Coverage Status
Change from base Build 13845349876: 0.0%
Covered Lines: 18425
Relevant Lines: 19331

💛 - Coveralls

Copy link
Collaborator

@IvanIsCoding IvanIsCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! This is good to go. Some of those docstrings are at least 5 years old now, so it is good they are getting some attention now.

I left some comments on that I will apply myself, Python needs to be capitalized and we are clearly not doing it.

@@ -1275,15 +1281,15 @@ impl PyDiGraph {
Ok(out_index)
}

/// Add new edges to the dag.
/// Add new edges to the graph.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find! Originally PyDiGraph was only for DAGs. PyDAG took that role later

@IvanIsCoding IvanIsCoding enabled auto-merge March 15, 2025 16:50
@IvanIsCoding IvanIsCoding added this to the 0.17.0 milestone Mar 15, 2025
@IvanIsCoding IvanIsCoding added this pull request to the merge queue Mar 15, 2025
Merged via the queue into Qiskit:main with commit 4c87245 Mar 15, 2025
31 checks passed
@eumiro eumiro deleted the docstrings-digraph branch March 15, 2025 17:54
SILIZ4 pushed a commit to SILIZ4/rustworkx that referenced this pull request Jul 4, 2025
* Consolidate docstrings in digraph.rs

* Apply suggestions from code review

---------

Co-authored-by: Ivan Carvalho <8753214+IvanIsCoding@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants